[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #2006: chore: add validate trigger and correct tip message for limit-count plugin

[GitBox <gi...@apache.org>]

iamayushdas commented on a change in pull request #2006:
URL: https://github.com/apache/apisix-dashboard/pull/2006#discussion_r679889837



##########
File path: web/cypress/integration/consumer/create-consumer-with-limit-count-plugin-form.spec.js
##########
@@ -46,7 +46,9 @@ context('Create and delete consumer with limit-count plugin form', () => {
     consumerName: 'test_consumer',
     description: 'desc_by_autotest',
     createConsumerSuccess: 'Create Consumer Successfully',
-    deleteConsumerSuccess: 'Delete Consumer Successfully'
+    deleteConsumerSuccess: 'Delete Consumer Successfully',
+    redisClusterName: 'Please Enter redis_cluster_name',
+    redisClusterNode: 'Please Enter redis_cluster_node',

Review comment:
       ```suggestion
       redisClusterNode: 'Please Enter node for Redis Cluster',
   ```

##########
File path: web/cypress/integration/consumer/create-consumer-with-limit-count-plugin-form.spec.js
##########
@@ -46,7 +46,9 @@ context('Create and delete consumer with limit-count plugin form', () => {
     consumerName: 'test_consumer',
     description: 'desc_by_autotest',
     createConsumerSuccess: 'Create Consumer Successfully',
-    deleteConsumerSuccess: 'Delete Consumer Successfully'
+    deleteConsumerSuccess: 'Delete Consumer Successfully',
+    redisClusterName: 'Please Enter redis_cluster_name',

Review comment:
       ```suggestion
       redisClusterName: 'Please Enter name of Redis Cluster',
   ```

##########
File path: web/cypress/integration/route/create-route-with-limit-count-plugin-form.spec.js
##########
@@ -51,6 +51,8 @@ context('Create and delete route with limit-count form', () => {
     submitSuccess: 'Submit Successfully',
     port: '80',
     weight: 1,
+    redisClusterName: 'Please Enter redis_cluster_name',

Review comment:
       ditto




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org