[jira] [Commented] (HBASE-18406) In ServerCrashProcedure.java start(MasterProcedureEnv) is a no-op

["Umesh Agashe (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-18406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16092359#comment-16092359 ] 

Umesh Agashe commented on HBASE-18406:
--------------------------------------

[~awleblang], looks good. Only one comment, following line would be nice for debugging:
{code}
LOG.info("Start " + this);
{code}

> In ServerCrashProcedure.java start(MasterProcedureEnv) is a no-op
> -----------------------------------------------------------------
>
>                 Key: HBASE-18406
>                 URL: https://issues.apache.org/jira/browse/HBASE-18406
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Alex Leblang
>            Assignee: Alex Leblang
>         Attachments: HBASE-18406.master.001.patch
>
>
> The comments above this method explain that it exists to set configs and return, however, no configs are set in the method.  
> As you can see here:
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L210-L214 
> It is only ever called here:
> https://github.com/apache/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/ServerCrashProcedure.java#L142



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)