[GitHub] [spark] JoshRosen commented on issue #26993: [SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter

[GitBox <gi...@apache.org>]

JoshRosen commented on issue #26993: [SPARK-30338][SQL] Avoid unnecessary InternalRow copies in ParquetRowConverter
URL: https://github.com/apache/spark/pull/26993#issuecomment-569844651
 
 
   I've removed the `[WIP]` tag and I think this is now ready for review.
   
    I've updated the existing "map with struct values" test so that it uses maps with multiple values (previously, we only tested with maps that contained one entry and that's insufficient to detect struct-copying problems (i.e. the old test would still pass if I completely removed the `.copy()` calls, whereas the new test will fail). For completeness, I also added a test for "maps with struct _keys_". I also changed the style of the new "struct of structs" test case in order to better match the style of this suite's existing tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org