You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "shunping (via GitHub)" <gi...@apache.org> on 2026/04/30 15:03:51 UTC
[PR] Add some more logging into boot.go to facilitate future environment debugging [beam]
shunping opened a new pull request, #38342:
URL: https://github.com/apache/beam/pull/38342
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve logging in boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3175822975
##########
sdks/python/container/boot.go:
##########
@@ -410,10 +410,10 @@ func setupVenv(ctx context.Context, logger *tools.Logger, baseDir, workerId stri
// installSetupPackages installs Beam SDK and user dependencies.
func installSetupPackages(ctx context.Context, logger *tools.Logger, files []string, workDir string, requirementsFiles []string) error {
bufLogger := tools.NewBufferedLogger(logger)
- bufLogger.Printf(ctx, "Installing setup packages ...")
+ bufLogger.Printf(ctx, "Installing Beam SDK and user dependencies ...")
Review Comment:
so i'd skip Beam SDK from this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169833986
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
The new logs only add 4 lines and are already emitted at the DEBUG level, which allows users to filter them out as needed.
Given this minimal footprint, I’d prefer to avoid adding complexity of a new configuration mechanism or flag in `boot.go` to keep the boot logic as simple as possible.
<img width="2058" height="494" alt="image" src="https://github.com/user-attachments/assets/ea5b8041-cc60-4d4c-99f0-e9d462d4337e" />
> 'pre-installation', 'post-installation' sounds a bit cryptic for end user who is not a beam dev.
I used the term "installation" because of the line of "Installing setup packages ..." prior to these logs (see above screenshot too), but I am open to any better term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169833986
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
The new logs only add 4 lines and are already emitted at the DEBUG level, which allows users to filter them out as needed.
Given this minimal footprint, I’d prefer to avoid adding complexity of a new configuration mechanism or flag in `boot.go` to keep the boot logic as simple as possible.
<img width="2058" height="494" alt="image" src="https://github.com/user-attachments/assets/ea5b8041-cc60-4d4c-99f0-e9d462d4337e" />
> 'pre-installation', 'post-installation' sounds a bit cryptic for end user who is not a beam dev.
I used the term "installation" because of the line of "Installing setup packages ..." prior to these logs (see above screenshot too), but I am open to any better term.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add some more logging into boot.go to facilitate future environment debugging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on PR #38342:
URL: https://github.com/apache/beam/pull/38342#issuecomment-4353660131
r: @tvalentyn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169399294
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
What is the use-case for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169518479
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
We called the same function after installation. However if any of the installation steps fail, boot.go will exit the process before reaching this function.
That's why I want to call the same function before installation. This ensures we have that we will be able to see the information no matter the installation is successful or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3168990559
##########
sdks/python/container/boot.go:
##########
@@ -485,20 +493,20 @@ func processArtifactsInSetupOnlyMode() {
// logRuntimeDependencies logs the python dependencies
// installed in the runtime environment.
-func logRuntimeDependencies(ctx context.Context, bufLogger *tools.BufferedLogger) error {
+func logRuntimeDependencies(ctx context.Context, bufLogger *tools.BufferedLogger, phase string) error {
pythonVersion, err := expansionx.GetPythonVersion()
if err != nil {
return err
}
- bufLogger.Printf(ctx, "Using Python version:")
+ bufLogger.Printf(ctx, "Using Python version (%s):", phase)
args := []string{"--version"}
if err := execx.ExecuteEnvWithIO(nil, os.Stdin, bufLogger, bufLogger, pythonVersion, args...); err != nil {
bufLogger.FlushAtError(ctx)
} else {
bufLogger.FlushAtDebug(ctx)
}
- bufLogger.Printf(ctx, "Logging runtime dependencies:")
- args = []string{"-m", "pip", "freeze"}
+ bufLogger.Printf(ctx, "Logging runtime dependencies (%s):", phase)
+ args = []string{"-m", "pip", "freeze", "--all"}
Review Comment:
The argument "--all" ensures that the versions of pip, setuptools, etc are included in the result.
##########
sdks/python/container/boot.go:
##########
@@ -485,20 +493,20 @@ func processArtifactsInSetupOnlyMode() {
// logRuntimeDependencies logs the python dependencies
// installed in the runtime environment.
-func logRuntimeDependencies(ctx context.Context, bufLogger *tools.BufferedLogger) error {
+func logRuntimeDependencies(ctx context.Context, bufLogger *tools.BufferedLogger, phase string) error {
pythonVersion, err := expansionx.GetPythonVersion()
if err != nil {
return err
}
- bufLogger.Printf(ctx, "Using Python version:")
+ bufLogger.Printf(ctx, "Using Python version (%s):", phase)
args := []string{"--version"}
if err := execx.ExecuteEnvWithIO(nil, os.Stdin, bufLogger, bufLogger, pythonVersion, args...); err != nil {
bufLogger.FlushAtError(ctx)
} else {
bufLogger.FlushAtDebug(ctx)
}
- bufLogger.Printf(ctx, "Logging runtime dependencies:")
- args = []string{"-m", "pip", "freeze"}
+ bufLogger.Printf(ctx, "Logging runtime dependencies (%s):", phase)
+ args = []string{"-m", "pip", "freeze", "--all"}
Review Comment:
The argument `"--all"` ensures that the versions of pip, setuptools, etc are included in the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3175764402
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
Great. I made the change to use "initial runtime environmemnt" and "final runtime environment". Some small edits to existing messages to make them consistent and concise. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3170194513
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
i do think that the `pre-installation` output is confusing unless you know why you need to look at it; most of the time, you need to look at the final output.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add some more logging into boot.go to facilitate future environment debugging [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38342:
URL: https://github.com/apache/beam/pull/38342#issuecomment-4353603724
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request improves the observability of the SDK container boot process by adding more granular logging. These changes facilitate easier debugging of environment-specific issues by providing clearer insights into pipeline configurations, experiment settings, and the state of Python dependencies before and after package installation.
### Highlights
* **Enhanced Logging**: Added detailed logging for PipelineOptions and Experiments to improve visibility during the boot process.
* **Dependency Tracking**: Updated the runtime dependency logging to include a phase identifier and capture all installed packages using 'pip freeze --all'.
* **Pre-installation Diagnostics**: Integrated a pre-installation dependency check to better diagnose environment states before package installation.
🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169518479
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
We called the same function after installation. However if any of the installation steps fail, boot.go will exit the process before reaching this function.
In such as case, dumping the runtime dependency beforehand ensures we have that information no matter the installation is successful or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169518479
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
We called the same function after installation. However if any of the installation steps fail, boot.go will exit the process before reaching this function.
That's why I want to call the same function before installation. This ensures we have that we will be able to see the information no matter the installation is successful or not. This information is also helpful for us to reproduce the customer environment if they see installation failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future environment debugging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3168954307
##########
sdks/python/container/boot.go:
##########
@@ -183,12 +183,17 @@ func launchSDKProcess() error {
if err != nil {
logger.Fatalf(ctx, "Failed to convert pipeline options: %v", err)
}
+ logger.Printf(ctx, "PipelineOptions=%v", options)
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169518479
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
While we already log dependencies after installation, `boot.go` exits immediately if any installation step fails.
Adding a pre-installation call ensures we capture the environment state regardless of whether the installation succeeds. This is useful for reproducing and triaging environment-specific failures from customers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add some more logging into boot.go to facilitate future environment debugging [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3168890724
##########
sdks/python/container/boot.go:
##########
@@ -183,12 +183,17 @@ func launchSDKProcess() error {
if err != nil {
logger.Fatalf(ctx, "Failed to convert pipeline options: %v", err)
}
+ logger.Printf(ctx, "PipelineOptions=%v", options)
Review Comment:
 
Logging the entire `PipelineOptions` object is a security risk as it may contain sensitive information such as API keys, access tokens, or passwords passed as pipeline arguments. It is recommended to avoid logging the full object or to implement a scrubbing mechanism to mask sensitive fields before logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve logging in boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping merged PR #38342:
URL: https://github.com/apache/beam/pull/38342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169621463
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
'pre-installation', 'post-installation' sounds a bit cryptic for end user who is not a beam dev, and the output may be a a bit verbose.
How about we think of a way to enable debug logging for boot.go and only print pre-installation env if debug logging is enabled? then, we can ask affected customers to run their pipeline with debug logging enabled if necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3168990559
##########
sdks/python/container/boot.go:
##########
@@ -485,20 +493,20 @@ func processArtifactsInSetupOnlyMode() {
// logRuntimeDependencies logs the python dependencies
// installed in the runtime environment.
-func logRuntimeDependencies(ctx context.Context, bufLogger *tools.BufferedLogger) error {
+func logRuntimeDependencies(ctx context.Context, bufLogger *tools.BufferedLogger, phase string) error {
pythonVersion, err := expansionx.GetPythonVersion()
if err != nil {
return err
}
- bufLogger.Printf(ctx, "Using Python version:")
+ bufLogger.Printf(ctx, "Using Python version (%s):", phase)
args := []string{"--version"}
if err := execx.ExecuteEnvWithIO(nil, os.Stdin, bufLogger, bufLogger, pythonVersion, args...); err != nil {
bufLogger.FlushAtError(ctx)
} else {
bufLogger.FlushAtDebug(ctx)
}
- bufLogger.Printf(ctx, "Logging runtime dependencies:")
- args = []string{"-m", "pip", "freeze"}
+ bufLogger.Printf(ctx, "Logging runtime dependencies (%s):", phase)
+ args = []string{"-m", "pip", "freeze", "--all"}
Review Comment:
The argument "-all" ensures that the versions of pip, setuptools, etc are included in the result.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve logging in boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3175822975
##########
sdks/python/container/boot.go:
##########
@@ -410,10 +410,10 @@ func setupVenv(ctx context.Context, logger *tools.Logger, baseDir, workerId stri
// installSetupPackages installs Beam SDK and user dependencies.
func installSetupPackages(ctx context.Context, logger *tools.Logger, files []string, workDir string, requirementsFiles []string) error {
bufLogger := tools.NewBufferedLogger(logger)
- bufLogger.Printf(ctx, "Installing setup packages ...")
+ bufLogger.Printf(ctx, "Installing Beam SDK and user dependencies ...")
Review Comment:
so i'd remove Beam SDK from this line to avoid confusion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future environment debugging [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38342:
URL: https://github.com/apache/beam/pull/38342#issuecomment-4353672576
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3170194513
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
i do think that the `pre-installation` output is confusing unless you know why you need to look at it; most of the time, you need to look at the final list after all the installations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3170256478
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
Perhaps we could change logs to the below:
`Installing setup packages` -> `Installing additional runtime dependencies if any are specified in --requirements_file, --setup_file or --extra_package options.`
`post-installation`-> `post-installation (final runtime environment)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3169954565
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
sg, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add more logging into boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3175764402
##########
sdks/python/container/boot.go:
##########
@@ -408,6 +412,10 @@ func installSetupPackages(ctx context.Context, logger *tools.Logger, files []str
bufLogger := tools.NewBufferedLogger(logger)
bufLogger.Printf(ctx, "Installing setup packages ...")
+ if err := logRuntimeDependencies(ctx, bufLogger, "pre-installation"); err != nil {
Review Comment:
Great. I made the change to use "initial runtime environmemnt" and "final runtime environment". I also included some small edits to existing messages to make them consistent and concise. PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve logging in boot.go to facilitate future triaging [beam]
Posted by "tvalentyn (via GitHub)" <gi...@apache.org>.
tvalentyn commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3175822202
##########
sdks/python/container/boot.go:
##########
@@ -410,10 +410,10 @@ func setupVenv(ctx context.Context, logger *tools.Logger, baseDir, workerId stri
// installSetupPackages installs Beam SDK and user dependencies.
func installSetupPackages(ctx context.Context, logger *tools.Logger, files []string, workDir string, requirementsFiles []string) error {
bufLogger := tools.NewBufferedLogger(logger)
- bufLogger.Printf(ctx, "Installing setup packages ...")
+ bufLogger.Printf(ctx, "Installing Beam SDK and user dependencies ...")
Review Comment:
in prod, we almost never install beam sdk bc containers must have beam preinstalled. it is only installed if --sdk_location is specified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Improve logging in boot.go to facilitate future triaging [beam]
Posted by "shunping (via GitHub)" <gi...@apache.org>.
shunping commented on code in PR #38342:
URL: https://github.com/apache/beam/pull/38342#discussion_r3175830489
##########
sdks/python/container/boot.go:
##########
@@ -410,10 +410,10 @@ func setupVenv(ctx context.Context, logger *tools.Logger, baseDir, workerId stri
// installSetupPackages installs Beam SDK and user dependencies.
func installSetupPackages(ctx context.Context, logger *tools.Logger, files []string, workDir string, requirementsFiles []string) error {
bufLogger := tools.NewBufferedLogger(logger)
- bufLogger.Printf(ctx, "Installing setup packages ...")
+ bufLogger.Printf(ctx, "Installing Beam SDK and user dependencies ...")
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org