You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2022/08/24 14:29:40 UTC
[GitHub] [zookeeper] eolivelli commented on a diff in pull request #1905: ZOOKEEPER-4575: ZooKeeperServer#processPacket take record instead of bytes
eolivelli commented on code in PR #1905:
URL: https://github.com/apache/zookeeper/pull/1905#discussion_r953874796
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ByteBufferRequestRecord.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *uuuuu
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "/RequuuAS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import org.apache.jute.Record;
+
+public class ByteBufferRequestRecord implements RequestRecord {
+
+ private final ByteBuffer request;
+
+ private volatile Record record;
+
+ public ByteBufferRequestRecord(ByteBuffer request) {
+ this.request = request;
+ }
+
+ @Override
+ public <T extends Record> T readRecord(Class<T> clazz) throws IOException {
+ if (record != null) {
+ try {
+ return clazz.cast(record);
+ } catch (Exception e) {
+ throw new IOException(e);
+ }
+ }
+
+ try {
+ record = clazz.getDeclaredConstructor().newInstance();
Review Comment:
we shouldn't use reflection here in a hot path (while processing requests) reflection is really slow
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ByteBufferRequestRecord.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *uuuuu
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "/RequuuAS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import org.apache.jute.Record;
+
+public class ByteBufferRequestRecord implements RequestRecord {
+
+ private final ByteBuffer request;
+
+ private volatile Record record;
+
+ public ByteBufferRequestRecord(ByteBuffer request) {
+ this.request = request;
+ }
+
+ @Override
+ public <T extends Record> T readRecord(Class<T> clazz) throws IOException {
Review Comment:
we should avoid reflection at all.
the list of PDUs is known, we can have a static map
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java:
##########
@@ -359,9 +355,6 @@ protected void pRequest2Txn(int type, long zxid, Request request, Record record,
case OpCode.delete:
zks.sessionTracker.checkSession(request.sessionId, request.getOwner());
DeleteRequest deleteRequest = (DeleteRequest) record;
- if (deserialize) {
Review Comment:
is this a behaviour change ? were is the deserialisation happening ?
are we doing it more times now ?
##########
zookeeper-server/src/main/java/org/apache/zookeeper/server/ByteBufferRequestRecord.java:
##########
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *uuuuu
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "/RequuuAS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.zookeeper.server;
+
+import java.io.IOException;
+import java.nio.ByteBuffer;
+import org.apache.jute.Record;
+
+public class ByteBufferRequestRecord implements RequestRecord {
+
+ private final ByteBuffer request;
+
+ private volatile Record record;
+
+ public ByteBufferRequestRecord(ByteBuffer request) {
+ this.request = request;
+ }
+
+ @Override
+ public <T extends Record> T readRecord(Class<T> clazz) throws IOException {
+ if (record != null) {
+ try {
+ return clazz.cast(record);
Review Comment:
`return (T) record`
it should be more efficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org