[GitHub] [arrow] pitrou commented on a change in pull request #12062: ARROW-15173: [R] Provide backward compatibility for bridge to older versions of pyarrow

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #12062:
URL: https://github.com/apache/arrow/pull/12062#discussion_r778163085



##########
File path: r/R/python.R
##########
@@ -181,9 +257,15 @@ r_to_py.RecordBatchReader <- function(x, convert = FALSE) {
   pa <- reticulate::import("pyarrow", convert = FALSE)
   x$export_to_c(stream_ptr)
   # TODO: handle subclasses of RecordBatchReader?
-  out <- pa$lib$RecordBatchReader$`_import_from_c`(
-    stream_ptr
-  )
+
+  if (pyarrow_version() >= pyarrow_version_pointers_changed()) {

Review comment:
       Will this actually compare version strings, such that "10.0.0" is smaller than "7.0.0"?
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org