[GitHub] [iceberg] szehon-ho commented on a diff in pull request #6661: Core: Support delete file stats in partitions metadata table

["szehon-ho (via GitHub)" <gi...@apache.org>]

szehon-ho commented on code in PR #6661:
URL: https://github.com/apache/iceberg/pull/6661#discussion_r1183129681


##########
core/src/main/java/org/apache/iceberg/PartitionsTable.java:
##########
@@ -90,54 +118,60 @@ private DataTask task(StaticTableScan scan) {
 
   private static StaticDataTask.Row convertPartition(Partition partition) {
     return StaticDataTask.Row.of(
-        partition.key, partition.specId, partition.dataRecordCount, partition.dataFileCount);
+        partition.key,
+        partition.specId,
+        partition.dataRecordCount,
+        partition.dataFileCount,
+        partition.posDeleteRecordCount,
+        partition.posDeleteFileCount,
+        partition.eqDeleteRecordCount,
+        partition.eqDeleteFileCount);
   }
 
   private static Iterable<Partition> partitions(Table table, StaticTableScan scan) {
     Types.StructType normalizedPartitionType = Partitioning.partitionType(table);
     PartitionMap partitions = new PartitionMap();
 
-    // cache a position map needed by each partition spec to normalize partitions to final schema
-    Map<Integer, int[]> normalizedPositionsBySpec =
-        Maps.newHashMapWithExpectedSize(table.specs().size());
+    try (CloseableIterable<DataFile> datafiles = planDataFiles(scan);

Review Comment:
   @ajantha-bhat can we see about this?  Will it work to wrap the manifest iterable to get the right type in planDataFiles()?
   
   ```
   CloseableIterable.transform(ManifestFiles.read(manifest, table.io(), table.specs())
           .caseSensitive(scan.isCaseSensitive())
           .select(BaseScan.SCAN_COLUMNS).entries(), t -> (ContentFile<?>) t);
   ```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org