[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #3237: [Hotfix][e2e] fix JobRestoreWhenMasterNodeSwitch method NP

[GitBox <gi...@apache.org>]

EricJoy2048 commented on code in PR #3237:
URL: https://github.com/apache/incubator-seatunnel/pull/3237#discussion_r1009030936


##########
seatunnel-engine/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/CoordinatorServiceTest.java:
##########
@@ -154,7 +154,7 @@ public void testJobRestoreWhenMasterNodeSwitch() throws InterruptedException {
             });
 
         // wait job restore
-        Thread.sleep(5000);
+        Thread.sleep(30000);

Review Comment:
   `Thread.sleep(5000) ` is used to wait the job begin restore and job status turn to a non `RUNNING` status. And then I use 
   
   ```
   // pipeline will recovery running state
           await().atMost(200000, TimeUnit.MILLISECONDS)
               .untilAsserted(
                   () -> Assertions.assertEquals(PipelineStatus.RUNNING,
                       server2.getCoordinatorService().getJobMaster(jobId).getPhysicalPlan().getPipelineList().get(0)
                           .getPipelineState()));
   
   ```
   
   to ensure the job restore complete and job status turn to running again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org