You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by du...@apache.org on 2023/05/16 08:37:54 UTC
[shardingsphere] branch master updated: Optimize DDLStatement.g4 support CREATE TABLE with START TRANSACTION. (#25687)
This is an automated email from the ASF dual-hosted git repository.
duanzhengqiang pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new bd6e65f99b2 Optimize DDLStatement.g4 support CREATE TABLE with START TRANSACTION. (#25687)
bd6e65f99b2 is described below
commit bd6e65f99b21a387834d721bb377bcfdd9f4fc9c
Author: Cong Hu <ia...@qq.com>
AuthorDate: Tue May 16 16:37:44 2023 +0800
Optimize DDLStatement.g4 support CREATE TABLE with START TRANSACTION. (#25687)
* Optimize DDLStatement.g4 support CREATE TABLE with START TRANSACTION.
* Update DDLStatement.g4
---
.../dialect/mysql/src/main/antlr4/imports/mysql/DDLStatement.g4 | 6 +++++-
test/it/parser/src/main/resources/case/ddl/create-table.xml | 7 +++++++
.../parser/src/main/resources/sql/supported/ddl/create-table.xml | 1 +
3 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/DDLStatement.g4 b/parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/DDLStatement.g4
index 4ac5a702afe..77a65e3fef4 100644
--- a/parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/DDLStatement.g4
+++ b/parser/sql/dialect/mysql/src/main/antlr4/imports/mysql/DDLStatement.g4
@@ -32,7 +32,11 @@ alterStatement
;
createTable
- : CREATE TEMPORARY? TABLE ifNotExists? tableName (createDefinitionClause? createTableOptions? partitionClause? duplicateAsQueryExpression? | createLikeClause)
+ : CREATE TEMPORARY? TABLE ifNotExists? tableName (createDefinitionClause? createTableOptions? partitionClause? duplicateAsQueryExpression? startTransaction? | createLikeClause)
+ ;
+
+startTransaction
+ : START TRANSACTION
;
partitionClause
diff --git a/test/it/parser/src/main/resources/case/ddl/create-table.xml b/test/it/parser/src/main/resources/case/ddl/create-table.xml
index d50b77b19aa..339afba6e0e 100644
--- a/test/it/parser/src/main/resources/case/ddl/create-table.xml
+++ b/test/it/parser/src/main/resources/case/ddl/create-table.xml
@@ -1814,4 +1814,11 @@
<column name="g" />
</column-definition>
</create-table>
+
+ <create-table sql-case-id="create_table_with_start_transaction">
+ <table name="t_order" start-index="13" stop-index="19" />
+ <column-definition type="INT" start-index="22" stop-index="33">
+ <column name="order_id" />
+ </column-definition>
+ </create-table>
</sql-parser-test-cases>
diff --git a/test/it/parser/src/main/resources/sql/supported/ddl/create-table.xml b/test/it/parser/src/main/resources/sql/supported/ddl/create-table.xml
index 36346ab968f..e701191e2c5 100644
--- a/test/it/parser/src/main/resources/sql/supported/ddl/create-table.xml
+++ b/test/it/parser/src/main/resources/sql/supported/ddl/create-table.xml
@@ -130,4 +130,5 @@
<sql-case id="create_table_with_varchar2_char_and_byte_type" value="CREATE TABLE t_order (SYS_ID VARCHAR2(32 CHAR) VISIBLE NOT NULL, ATTACHMENT_NAME VARCHAR2(1024 BYTE) VISIBLE DEFAULT '')" db-types="Oracle" />
<sql-case id="create_table_with_character_varying" value="CREATE TABLE t_order (order_id INT, user_id INT, status CHARACTER VARYING(50))" db-types="MySQL" />
<sql-case id="create_table_with_geomcollection" value="CREATE TABLE t1 (g GEOMCOLLECTION)" db-types="MySQL" />
+ <sql-case id="create_table_with_start_transaction" value="CREATE TABLE t_order (order_id INT) START TRANSACTION" db-types="MySQL" />
</sql-cases>