[jira] Commented: (JCR-1538) [patch] add toString for NodeImpl and PropertyImpl

["Thomas Mueller (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/JCR-1538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12588936#action_12588936 ] 

Thomas Mueller commented on JCR-1538:
-------------------------------------

Hi,

The patch looks good, but maybe it can still be improved. Your implementation calls quite heavyweight methods that can throw RepositoryException. Maybe they throw unchecked exceptions as well (I recently had a problem with NullPointerException  in a toString() method). Catching Exception instead of just RepositoryException would be safer I guess. What about appending super.toString() in all cases (even if no exception occurs)? That way, you could detect it's the same object before and after the session is closed.

Regards,
Thomas

> [patch] add toString for NodeImpl and PropertyImpl
> --------------------------------------------------
>
>                 Key: JCR-1538
>                 URL: https://issues.apache.org/jira/browse/JCR-1538
>             Project: Jackrabbit
>          Issue Type: Improvement
>          Components: jackrabbit-core
>    Affects Versions: core 1.4.2
>            Reporter: Dave Brosius
>            Priority: Trivial
>             Fix For: 1.5
>
>         Attachments: node_and_property_toString.patch
>
>
> add toString for NodeImpl and PropertyImpl with new format. see how it is liked, before adding more.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.