You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@allura.apache.org by Dave Brondsema <br...@users.sf.net> on 2013/07/01 16:43:52 UTC

[allura:tickets] #6211 widget template shouldn't extend g.theme.master

- **QA**: Dave Brondsema



---

** [tickets:#6211] widget template shouldn't extend g.theme.master**

**Status:** code-review
**Labels:** stability 42cc 
**Created:** Tue May 07, 2013 07:35 PM UTC by Dave Brondsema
**Last Updated:** Wed Jun 19, 2013 12:36 PM UTC
**Owner:** nobody

allura/templates/discussion/index.html isn't a full template that extends g.theme.master  ON forum browse pages, it eventually calls forgediscussion/templates/discussion_widgets/discussion.html which is a widget template but does extend g.theme.master  That is non-standard and has the effect of template globals (like `config`) not being present within the `custom_js` theme macro.

We should see if these templates (and any other related ones) can be made more standard, to avoid such issues.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a mailing list, you can unsubscribe from the mailing list.