You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@ofbiz.apache.org by GitBox <gi...@apache.org> on 2021/12/07 12:46:32 UTC

[GitHub] [ofbiz-framework] JacquesLeRoux commented on pull request #391: Improved: AccountingUiLabels clean-up (OFBIZ-9352)

JacquesLeRoux commented on pull request #391:
URL: https://github.com/apache/ofbiz-framework/pull/391#issuecomment-987893446


   Pierre,
   
   Today I asked myself (again): "Some efforts have been done to produce those. Are we sure we want to remove them? This does not break anything and can still be used in projects that could be updated and missing these labels." 
   
   I then checked, we had this discussion many time already (mostly, in order of appeareance):
   https://markmail.org/message/so4gyq6ph4udh6cm (2016)
   https://issues.apache.org/jira/browse/OFBIZ-8154 (2016)
   https://issues.apache.org/jira/browse/OFBIZ-9352 (2017)
   https://issues.apache.org/jira/browse/OFBIZ-10565 (2018 umbrella task)
   https://markmail.org/message/7kckrtpzw5r7fvkl (2020)
   
   After that I decided to apply what we discussed before: check if it's not used anywhere, then remove. I'm still not sure it's the best decision, but it's the one we decided on.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org