You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tika.apache.org by GitBox <gi...@apache.org> on 2021/05/11 01:39:48 UTC

[GitHub] [tika] kamaci commented on a change in pull request #437: fix for TIKA-3390 contributed by kamaci

kamaci commented on a change in pull request #437:
URL: https://github.com/apache/tika/pull/437#discussion_r629789195



##########
File path: tika-parsers/tika-parsers-classic/tika-parsers-classic-modules/tika-parser-microsoft-module/src/main/java/org/apache/tika/parser/microsoft/onenote/ExtendedGUID.java
##########
@@ -35,7 +35,7 @@ public static ExtendedGUID nil() {
     @Override
     public int compareTo(ExtendedGUID other) {
         if (other.guid.equals(guid)) {
-            new Long(n).compareTo(other.n);
+            return Long.compare(n, other.n);

Review comment:
       I've changed it like that since it seems like a bug.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org