You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/02/24 19:18:29 UTC
[GitHub] [airflow] potiuk opened a new pull request #7525: [AIRFLOW-XXXX]
[WIP] Fix (?) flaky tests in kubernetes tests
potiuk opened a new pull request #7525: [AIRFLOW-XXXX] [WIP] Fix (?) flaky tests in kubernetes tests
URL: https://github.com/apache/airflow/pull/7525
NOTE - needs JIRA ticket (got temporary JIRA unavailability when creating it)
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [ ] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7525: [AIRFLOW-6906] Fix
flaky tests in kubernetes tests
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7525: [AIRFLOW-6906] Fix flaky tests in kubernetes tests
URL: https://github.com/apache/airflow/pull/7525
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7525:
[AIRFLOW-XXXX] [WIP] Fix (?) flaky tests in kubernetes tests
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7525: [AIRFLOW-XXXX] [WIP] Fix (?) flaky tests in kubernetes tests
URL: https://github.com/apache/airflow/pull/7525#discussion_r383487640
##########
File path: tests/runtime/kubernetes/test_kubernetes_executor.py
##########
@@ -88,6 +88,9 @@ def monitor_task(self, host, execution_date, dag_id, task_id, expected_final_sta
execution_date=execution_date,
task_id=task_id)
)
+ if result.status_code == 404:
+ check_call(["echo", "api returned 404."])
Review comment:
What is this for?
Quoting from slack too from Matt:
>One thing I thought of, correct me if I’m wrong, is there a possibility for an infinite loop? Say the status always returns 404, tries also would not increment. Maybe put the tries increment at the beginning of the loop and increase the max_tries?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7525:
[AIRFLOW-XXXX] [WIP] Fix (?) flaky tests in kubernetes tests
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7525: [AIRFLOW-XXXX] [WIP] Fix (?) flaky tests in kubernetes tests
URL: https://github.com/apache/airflow/pull/7525#discussion_r383495668
##########
File path: tests/runtime/kubernetes/test_kubernetes_executor.py
##########
@@ -88,6 +88,9 @@ def monitor_task(self, host, execution_date, dag_id, task_id, expected_final_sta
execution_date=execution_date,
task_id=task_id)
)
+ if result.status_code == 404:
+ check_call(["echo", "api returned 404."])
Review comment:
Ah yeah! tries += 1 is missing. Great catch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7525: [AIRFLOW-6906] Fix
flaky tests in kubernetes tests
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7525: [AIRFLOW-6906] Fix flaky tests in kubernetes tests
URL: https://github.com/apache/airflow/pull/7525#issuecomment-590586789
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7525?src=pr&el=h1) Report
> Merging [#7525](https://codecov.io/gh/apache/airflow/pull/7525?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/b4ce8f22f6b13b2ae33b107a4e479081442a988b?src=pr&el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/airflow/pull/7525?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7525 +/- ##
==========================================
- Coverage 86.66% 86.62% -0.04%
==========================================
Files 893 893
Lines 42242 42266 +24
==========================================
+ Hits 36610 36614 +4
- Misses 5632 5652 +20
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7525?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0%> (-64.16%)` | :arrow_down: |
| [airflow/security/kerberos.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWN1cml0eS9rZXJiZXJvcy5weQ==) | `30.43% <0%> (-45.66%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55% <0%> (-45%)` | :arrow_down: |
| [airflow/stats.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9zdGF0cy5weQ==) | `83.56% <0%> (-1.74%)` | :arrow_down: |
| [airflow/providers/apache/hive/hooks/hive.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvaG9va3MvaGl2ZS5weQ==) | `76.02% <0%> (-1.54%)` | :arrow_down: |
| [airflow/jobs/backfill\_job.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9qb2JzL2JhY2tmaWxsX2pvYi5weQ==) | `90.98% <0%> (-1.13%)` | :arrow_down: |
| [airflow/hooks/dbapi\_hook.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9kYmFwaV9ob29rLnB5) | `90.9% <0%> (-0.83%)` | :arrow_down: |
| [airflow/models/dagrun.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9tb2RlbHMvZGFncnVuLnB5) | `95.76% <0%> (-0.06%)` | :arrow_down: |
| [...providers/microsoft/azure/hooks/azure\_fileshare.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbWljcm9zb2Z0L2F6dXJlL2hvb2tzL2F6dXJlX2ZpbGVzaGFyZS5weQ==) | `100% <0%> (ø)` | :arrow_up: |
| [airflow/kubernetes/worker\_configuration.py](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3dvcmtlcl9jb25maWd1cmF0aW9uLnB5) | `99.3% <0%> (+0.01%)` | :arrow_up: |
| ... and [7 more](https://codecov.io/gh/apache/airflow/pull/7525/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7525?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7525?src=pr&el=footer). Last update [b4ce8f2...07cd7b5](https://codecov.io/gh/apache/airflow/pull/7525?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7525:
[AIRFLOW-XXXX] [WIP] Fix (?) flaky tests in kubernetes tests
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7525: [AIRFLOW-XXXX] [WIP] Fix (?) flaky tests in kubernetes tests
URL: https://github.com/apache/airflow/pull/7525#discussion_r383487726
##########
File path: tests/runtime/kubernetes/test_kubernetes_executor.py
##########
@@ -88,6 +88,9 @@ def monitor_task(self, host, execution_date, dag_id, task_id, expected_final_sta
execution_date=execution_date,
task_id=task_id)
)
+ if result.status_code == 404:
+ check_call(["echo", "api returned 404."])
Review comment:
https://apache-airflow.slack.com/archives/CCPRP7943/p1582572265058300?thread_ts=1582567409.032300&cid=CCPRP7943
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services