You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by danbroudy <no...@github.com> on 2015/06/01 22:15:02 UTC
[jclouds-labs-google] Disable MultipartUploads tests (#144)
Until they are implemented they should be disabled.
You can view, comment on, or merge this pull request online at:
https://github.com/jclouds/jclouds-labs-google/pull/144
-- Commit Summary --
* disable MultipartUploads tests
-- File Changes --
M google-cloud-storage/src/test/java/org/jclouds/googlecloudstorage/blobstore/integration/GoogleCloudStorageBlobIntegrationLiveTest.java (18)
-- Patch Links --
https://github.com/jclouds/jclouds-labs-google/pull/144.patch
https://github.com/jclouds/jclouds-labs-google/pull/144.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144
Re: [jclouds-labs-google] Disable MultipartUploads tests (#144)
Posted by Andrew Gaul <no...@github.com>.
Can you tag the commit message with [JCLOUDS-894](https://issues.apache.org/jira/browse/JCLOUDS-894)?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144#issuecomment-107698921
Re: [jclouds-labs-google] Disable MultipartUploads tests (#144)
Posted by Andrew Gaul <no...@github.com>.
Squashed and pushed to master as 9c2d5ce954ee7427dce77306800f265e0e28cf53.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144#issuecomment-107743759
Re: [jclouds-labs-google] Disable MultipartUploads tests (#144)
Posted by Andrew Gaul <no...@github.com>.
> public void testPutFileParallel() throws SkipException {
> - // Implement Parallel uploads
> + throw new SkipException("Implement Parallel uploads");
> + // TODO: Implement Parallel uploads
Why do we disable this test? It passes when running it locally. I see these failures:
```
Failed tests:
GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testGetRangeOutOfRange:376 Invalid range not caught
GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testMultipartUploadMultipleParts:919 » UnsupportedOperation
GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testMultipartUploadNoPartsAbort:859 » UnsupportedOperation
GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testMultipartUploadSinglePart:885 » UnsupportedOperation
GoogleCloudStorageBlobIntegrationLiveTest>BaseBlobIntegrationTest.testPutInputStream:599->BaseBlobIntegrationTest.testPut:655 » HttpResponse
DefaultObjectAccessControlsApiLiveTest.testCreateDefaultObjectAcl:49->createBucket:43 » HttpResponse
ResumableUploadApiLiveTest.testResumableChunkedUpload:140 » HttpResponse comma...
ObjectApiLiveTest.deleteBucket:454 » IllegalState {
```
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144/files#r31476570
Re: [jclouds-labs-google] Disable MultipartUploads tests (#144)
Posted by Andrew Gaul <no...@github.com>.
> @@ -106,6 +106,24 @@ public void testPutFileParallel() throws SkipException {
> }
>
> @Override
> + @Test(enabled = false)
Instead of using `enabled = false`, throw `SkipException` so mvn flags these.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144/files#r31466985
Re: [jclouds-labs-google] Disable MultipartUploads tests (#144)
Posted by Andrew Gaul <no...@github.com>.
> @@ -106,6 +106,24 @@ public void testPutFileParallel() throws SkipException {
> }
>
> @Override
> + @Test(enabled = false)
> + public void testMultipartUploadSinglePart() throws SkipException {
> + // Implement MultipartUploads uploads
Add TODO: so IDEs highlight these?
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144/files#r31466953
Re: [jclouds-labs-google] Disable MultipartUploads tests (#144)
Posted by danbroudy <no...@github.com>.
> public void testPutFileParallel() throws SkipException {
> - // Implement Parallel uploads
> + throw new SkipException("Implement Parallel uploads");
> + // TODO: Implement Parallel uploads
I have checked and they are passing. I have re-enabled `testFileGetParallel` and `testPutFileParallel`
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144/files#r31478983
Re: [jclouds-labs-google] Disable MultipartUploads tests (#144)
Posted by Andrew Gaul <no...@github.com>.
Closed #144.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs-google/pull/144#event-319471221