[GitHub] [tvm] echuraev commented on a diff in pull request #12951: [CODEGEN][OPENCL] Sampler definition should be at outermost scope

[GitBox <gi...@apache.org>]

echuraev commented on code in PR #12951:
URL: https://github.com/apache/tvm/pull/12951#discussion_r984408792


##########
src/target/source/codegen_opencl.cc:
##########
@@ -89,6 +89,17 @@ void CodeGenOpenCL::InitFuncState(const PrimFunc& f) {
 
 void CodeGenOpenCL::PrintFuncPrefix() { stream << "__kernel void"; }
 
+void CodeGenOpenCL::PreFunctionBody(const PrimFunc& f) {
+  for (Var arg : f->params) {
+    auto ptr_type = arg->type_annotation.as<PointerTypeNode>();
+    if (ptr_type && runtime::IsTextureStorage(std::string(ptr_type->storage_scope))) {
+      this->stream << "  const sampler_t image_sampler = "

Review Comment:
   nit: Will we create this variable before function body in global scope? 
   If yes, then why we need this indent before `const sampler_t ...`?
   I suppose it should be something like that:
   ```
   const sampler_t image_sampler = "CLK_NORMALIZED_COORDS_FALSE | CLK_ADDRESS_CLAMP | CLK_FILTER_NEAREST;\n";
   __kernel void kernel_name(..) {
       // ...
   }
   ```
   Am I right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org