You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by combineads <gi...@git.apache.org> on 2016/09/23 00:22:30 UTC
[GitHub] nifi pull request #1052: NIFI-2803 The pagination of GenerateTableFetch has ...
GitHub user combineads opened a pull request:
https://github.com/apache/nifi/pull/1052
NIFI-2803 The pagination of GenerateTableFetch has a sort bug
When data is coming to the ingested table, the pagination SQL needs the ORDER BY statement with maxValueClauses.
If maxValueClauses are not the primary keys, incoming data usually inserts using primary keys. So when ExecuteSQL executes, some data may be lost.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/combineads/nifi NIFI-2803
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/1052.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1052
----
commit d27e5380ed490ee1aecd27a487b32b36e80c2594
Author: Byunghwa Yun <co...@combineads.co.kr>
Date: 2016-09-23T00:21:21Z
NIFI-2803 The pagination of GenerateTableFetch has a sort bug.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1052: NIFI-2803 The pagination of GenerateTableFetch has a sort ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1052
This commit breaks some unit tests that check the SQL statement(s) being generated, I will fix the tests before merging. Otherwise +1 LGTM, merging to master, thanks much for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #1052: NIFI-2803 The pagination of GenerateTableFetch has ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/1052
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #1052: NIFI-2803 The pagination of GenerateTableFetch has a sort ...
Posted by mattyb149 <gi...@git.apache.org>.
Github user mattyb149 commented on the issue:
https://github.com/apache/nifi/pull/1052
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---