You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@daffodil.apache.org by GitBox <gi...@apache.org> on 2018/10/15 21:05:22 UTC

[GitHub] mbeckerle commented on a change in pull request #126: Add default value for binaryCalendarEpoch

mbeckerle commented on a change in pull request #126: Add default value for binaryCalendarEpoch
URL: https://github.com/apache/incubator-daffodil/pull/126#discussion_r225316508
 
 

 ##########
 File path: daffodil-lib/src/main/resources/org/apache/daffodil/xsd/DFDLGeneralFormat.dfdl.xsd
 ##########
 @@ -29,6 +29,7 @@
           alignmentUnits="bytes"
           binaryFloatRep="ieee"
           binaryNumberRep="binary"
+          binaryCalendarEpoch="1970-01-01T00:00:00"
 
 Review comment:
   Pretty sure it should not have a timezone. The default behavior wants to be timezone is unspecified. Otherwise everyhting starts adding +00:00 to everything. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services