[GitHub] [arrow] romainfrancois commented on pull request #8549: ARROW-10386 [R]: List column class attributes not preserved in roundtrip

[GitBox <gi...@apache.org>]

romainfrancois commented on pull request #8549:
URL: https://github.com/apache/arrow/pull/8549#issuecomment-718689459


   This increases again the weight of the metadata, which now has to include attributes for each element of a list column, aka a struct array, but this seems on this example to work. 
   
   Can't use `sf` on the tests, so using something simpler: 
   
   ```r
   test_that("metadata of list elements (ARROW-10386)", {
     df <- data.frame(x = I(list(structure(1, foo = "bar"), structure(2, foo = "bar"))))
     tab <- Table$create(df)
     expect_identical(attr(as.data.frame(tab)$x[[1]], "foo"), "bar")
     expect_identical(attr(as.data.frame(tab)$x[[2]], "foo"), "bar")
   })
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org