You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by jo...@apache.org on 2023/08/16 16:51:08 UTC
[superset] branch master updated: fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627) (#24995)
This is an automated email from the ASF dual-hosted git repository.
johnbodley pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new 2b63577046 fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627) (#24995)
2b63577046 is described below
commit 2b63577046887f982a8b3a56b335f0c11288f829
Author: Elizabeth Thompson <es...@gmail.com>
AuthorDate: Wed Aug 16 09:51:00 2023 -0700
fix: Revert "fix(chart): Time Series set showMaxLabel as null for time xAxis (#20627) (#24995)
---
.../plugin-chart-echarts/src/Timeseries/transformProps.ts | 15 ++-------------
1 file changed, 2 insertions(+), 13 deletions(-)
diff --git a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
index 0f29282c5f..f76c457e1c 100644
--- a/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
+++ b/superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
@@ -20,7 +20,6 @@
import { invert } from 'lodash';
import {
AnnotationLayer,
- AxisType,
CategoricalColorNamespace,
ensureIsArray,
GenericDataType,
@@ -447,23 +446,13 @@ export default function transformProps(
rotate: xAxisLabelRotation,
},
minInterval:
- xAxisType === AxisType.time && timeGrainSqla
+ xAxisType === 'time' && timeGrainSqla
? TIMEGRAIN_TO_TIMESTAMP[timeGrainSqla]
: 0,
};
-
- if (xAxisType === AxisType.time) {
- /**
- * Overriding default behavior (false) for time axis regardless of the granilarity.
- * Not including this in the initial declaration above so if echarts changes the default
- * behavior for other axist types we won't unintentionally override it
- */
- xAxis.axisLabel.showMaxLabel = null;
- }
-
let yAxis: any = {
...defaultYAxis,
- type: logAxis ? AxisType.log : AxisType.value,
+ type: logAxis ? 'log' : 'value',
min,
max,
minorTick: { show: true },