You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by menaka121 <gi...@git.apache.org> on 2015/07/25 00:21:18 UTC
[GitHub] incubator-taverna-language pull request: Rovalidator
GitHub user menaka121 opened a pull request:
https://github.com/apache/incubator-taverna-language/pull/20
Rovalidator
The ro-bundle validation program.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/menaka121/incubator-taverna-language rovalidator
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-taverna-language/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit ed7e778811a2d722a5c04d345ebeddeabcedb537
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-21T18:32:21Z
Ro bundle validator
commit 0077fb69eb86d1285ae308cf86e704c6a9cd26ff
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-21T18:36:22Z
Apache license header
commit 3e5b4363d926b4f9b92d9e3a7a9cdc5d0e42e363
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-21T20:11:17Z
Validator test
commit 81fee89451f9c600a18d43da443f16d1839b7776
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-23T21:13:15Z
more explained way
commit 6c6dfa6c70797299d2a762da66f7b2abf9753787
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-23T22:24:35Z
Validation report class
commit 06bef782020e1de371d26b7a761905034b1d82d9
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-23T22:30:27Z
Report structure
commit 76e10395b217163ebda5f1540001610855001a12
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-24T19:07:04Z
Validation report complete
commit 57dd0eee16814385dbea60ad7478e28a96c160da
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-24T21:41:27Z
Stage 1 : Issue info level warning
commit a4c23189c7a1033c6c94c6550a728857ea7d9fdf
Author: Menaka Madushanka <me...@gmail.com>
Date: 2015-07-24T22:06:18Z
Issue fixed : have some performance considerations
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-language pull request: Rovalidator
Posted by stain <gi...@git.apache.org>.
Github user stain commented on the pull request:
https://github.com/apache/incubator-taverna-language/pull/20#issuecomment-128065222
Thanks!
Are you able to modify `ValidatorTest` a bit?
Instead of:
private Path path = Paths.get("src/test/resources/workflowrun.bundle.zip");
(which could risk overwriting the test bundle.zip )
Try something like (untested psevdocode):
```java
Path pathl
@Before
public void copyExample() {
path = Files.createTempFile("test", ".bundle.zip");
Files.copy(getClass().getResourceAsStream("/workflowrun.bundle.zip", path, CopyOptions.OVERWRITE);
}
```
Also could you check that the error lists etc are empty instead of just `System.out` which would not fail?
It would be great if the test could then temporarily break the bundle (as you can now that you copy it) to check the different errors and warnings.
BTW - could you maike it openBundleReadOnly in RoValidator?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-taverna-language pull request: Rovalidator
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-taverna-language/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---