[jira] [Updated] (HDFS-6578) add toString method to DatanodeStorage for easier debugging

["Arpit Agarwal (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/HDFS-6578?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arpit Agarwal updated HDFS-6578:
--------------------------------

    Summary: add toString method to DatanodeStorage for easier debugging  (was: add toString method to DatanodeStorage etc for easier debugging)

> add toString method to DatanodeStorage for easier debugging
> -----------------------------------------------------------
>
>                 Key: HDFS-6578
>                 URL: https://issues.apache.org/jira/browse/HDFS-6578
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Yongjun Zhang
>            Assignee: Yongjun Zhang
>         Attachments: HDFS-6578.001.patch, HDFS-6578.002.patch
>
>
> It seems to be nice to add a toString() method for DatanodeStorage class, so we can print out its key info easier while doing debuging.
> Another thing is, in the end of BlockManager#processReport, there is the following message,
> {code}
>    blockLog.info("BLOCK* processReport: from storage " + storage.getStorageID()
>         + " node " + nodeID + ", blocks: " + newReport.getNumberOfBlocks()
>         + ", processing time: " + (endTime - startTime) + " msecs");
>     return !node.hasStaleStorages();
> {code}
> We could add node.hasStaleStorages() to the log, and possibly replace storage.getSorateID() with the suggested storage.toString().
> Any comments? thanks.



--
This message was sent by Atlassian JIRA
(v6.2#6252)