[GitHub] [incubator-skywalking] wu-sheng opened a new pull request #2449: Query protocol and codebase for log type record

[GitBox <gi...@apache.org>]

wu-sheng opened a new pull request #2449: Query protocol and codebase for log type record
URL: https://github.com/apache/incubator-skywalking/pull/2449
 
 
   I just created `http_access_log` metric, with `queryLogs` protocol, see [GraphQL](https://github.com/apache/incubator-skywalking-query-protocol/blob/master/log.graphqls#L66) here. 
   
   @peng-yongsheng @TinyAllen @liuhaoyang @hanahmily 
   This PR includes codebase only but would use it in any case. In the future, I may want to open a receiver for log collector, such as logstash, etc.
   Do you think is it sensible to add traceId too for the future? Including in query protocol.
   
   @TinyAllen 
   The query protocol is related to UI more, let's add some new page? maybe. Use could query logs through time, (service, instance, endpoint)IDs, status, response time(2xx,4xx,5xx are expected codes)
   We need a discussion about this. If others thing traceid should be added, then I will adjust protocol.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services