You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/24 19:28:34 UTC

[GitHub] [airflow] potiuk opened a new pull request #21804: Make sure emphasis in UPDATING in .md is consistent

potiuk opened a new pull request #21804:
URL: https://github.com/apache/airflow/pull/21804


   There is a new rule in markdownlint which has been violated in
   main when new version of pre-commits is installed introduced in
   the #21734
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21804: Make sure emphasis in UPDATING in .md is consistent

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21804:
URL: https://github.com/apache/airflow/pull/21804#issuecomment-1050211583


   This is really strange - I even can't reinstall markdownlint from scratch now (TypeError: files.flat is not a function).... 
   This is rather bizarre.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21804: Make sure emphasis in UPDATING in .md is consistent

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21804:
URL: https://github.com/apache/airflow/pull/21804#issuecomment-1050195748


   It's just it was inconsistently used in this file - some emphasis used _ and some * :) (we had both in the file).
   Seems like a new rule added recently in markdownlint.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #21804: Make sure emphasis in UPDATING in .md is consistent

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21804:
URL: https://github.com/apache/airflow/pull/21804#issuecomment-1050193694


   Hmm I've already used underscore for emphasis/italics


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk commented on pull request #21804: Make sure emphasis in UPDATING in .md is consistent

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21804:
URL: https://github.com/apache/airflow/pull/21804#issuecomment-1050203806


   > Did we mean our version of markdownlint to change without explicit action?
   
   Nope. I was just looking at it why it did not install for me (but I wanted to quickly fix it first) 
   
   It is installed automatically by pre-commit - we have:
   
   ```
         - id: markdownlint
           name: Run markdownlint
           description: Checks the style of Markdown files.
           entry: markdownlint
           language: node
           types: [markdown]
           files: \.(md|mdown|markdown)$
           additional_dependencies: ['markdownlint-cli']
   ```
   
   And markdownlint-cli - drags markdownlint alongside: https://www.npmjs.com/package/markdownlint. Markdownlint was released on Jan 15 but if you had pre-commit installed locally, it did not upgrade to latest version.
   
   Apparenttly when you already had markdownlint-cli (thus markdownlint) installed by pre-commit, it would not trigger automated update to latest version. I am fixing this now.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] ashb commented on pull request #21804: Make sure emphasis in UPDATING in .md is consistent

Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #21804:
URL: https://github.com/apache/airflow/pull/21804#issuecomment-1050196888


   Did we mean our version of markdownlint to change without explicit action?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #21804: Make sure emphasis in UPDATING in .md is consistent

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21804:
URL: https://github.com/apache/airflow/pull/21804#issuecomment-1050193917


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] potiuk merged pull request #21804: Make sure emphasis in UPDATING in .md is consistent

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21804:
URL: https://github.com/apache/airflow/pull/21804


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org