[GitHub] [kafka] Nickstery commented on a diff in pull request #14104: Tiered storage | Segment with corrupted index should not be uploaded to remote storage

["Nickstery (via GitHub)" <gi...@apache.org>]

Nickstery commented on code in PR #14104:
URL: https://github.com/apache/kafka/pull/14104#discussion_r1276033212


##########
core/src/test/java/kafka/log/remote/RemoteLogManagerTest.java:
##########
@@ -558,6 +618,38 @@ void testCopyLogSegmentsToRemoteShouldNotCopySegmentForFollower() throws Excepti
         verify(mockLog, never()).updateHighestOffsetInRemoteStorage(anyLong());
     }
 
+    @Test
+    void testCopyLogSegmentsToRemoteShouldNotCopySegmentWithCorruptedIndexes() throws Exception {

Review Comment:
   I do not declare timeindex, 
   ```
   when(oldSegment.timeIndex()).thenReturn(new TimeIndex(TestUtils.tempFile(), baseOffset, maxEntries * 12));
   ```
   
   what means this file is missing



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org