You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Chris Nauroth (JIRA)" <ji...@apache.org> on 2012/10/19 20:19:11 UTC

[jira] [Created] (HADOOP-8949) FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win

Chris Nauroth created HADOOP-8949:
-------------------------------------

             Summary: FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win
                 Key: HADOOP-8949
                 URL: https://issues.apache.org/jira/browse/HADOOP-8949
             Project: Hadoop Common
          Issue Type: Task
          Components: fs
    Affects Versions: 1-win, trunk-win
            Reporter: Chris Nauroth
            Assignee: Chris Nauroth


We are converting to use winutils for Windows compatibility on external shell commands.  With those changes in place, the FileUtil.CygPathCommand inner class is no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (HADOOP-8949) FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win

Posted by "Suresh Srinivas (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Suresh Srinivas resolved HADOOP-8949.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: trunk-win
                   1-win
     Hadoop Flags: Reviewed

+1 for the patch. Committed to both branch-1-win and branch-trunk-win.

Thank you Chris.
                
> FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-8949
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8949
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs
>    Affects Versions: 1-win, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>             Fix For: 1-win, trunk-win
>
>         Attachments: HADOOP-8949-branch-1-win.patch, HADOOP-8949-branch-trunk-win.patch
>
>
> We are converting to use winutils for Windows compatibility on external shell commands.  With those changes in place, the FileUtil.CygPathCommand inner class is no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (HADOOP-8949) FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win

Posted by "Chris Nauroth (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HADOOP-8949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Nauroth updated HADOOP-8949:
----------------------------------

    Attachment: HADOOP-8949-branch-trunk-win.patch
                HADOOP-8949-branch-1-win.patch

I have attached patches for both branch-1-win and branch-trunk-win to remove the dead code.
                
> FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-8949
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8949
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs
>    Affects Versions: 1-win, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8949-branch-1-win.patch, HADOOP-8949-branch-trunk-win.patch
>
>
> We are converting to use winutils for Windows compatibility on external shell commands.  With those changes in place, the FileUtil.CygPathCommand inner class is no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (HADOOP-8949) FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win

Posted by "Brandon Li (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HADOOP-8949?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13487209#comment-13487209 ] 

Brandon Li commented on HADOOP-8949:
------------------------------------

Both patch look good to me. +1
                
> FileUtil.CygPathCommand is dead code on branch-1-win and branch-trunk-win
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-8949
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8949
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: fs
>    Affects Versions: 1-win, trunk-win
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>         Attachments: HADOOP-8949-branch-1-win.patch, HADOOP-8949-branch-trunk-win.patch
>
>
> We are converting to use winutils for Windows compatibility on external shell commands.  With those changes in place, the FileUtil.CygPathCommand inner class is no longer called.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira