You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/03/18 08:22:54 UTC
[GitHub] [flink] vthinkxie opened a new pull request #11436:
[FLINK-11404][web] add load more feature in exception page
vthinkxie opened a new pull request #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436
## What is the purpose of the change
ref https://issues.apache.org/jira/browse/FLINK-11404
## Brief change log
support more metric display at once
## Verifying this change
- *Submit a failover job*
- *Go to the exception (more than 10 exceptions)*
- *check if the load more button works*
before:
after:
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not documented)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on issue #11436: [FLINK-11404][web] add
load more feature in exception page
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-603108746
> I am reviewing this but it would be good if someone with more experience in TypeScript can give it another pass.
Hi @sorahn
do you have time to take a look?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11436: [FLINK-11404][web] add
load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11436: [FLINK-11404][web] add
load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600487531
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef (Wed Mar 18 08:25:17 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] sorahn commented on a change in pull request #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
sorahn commented on a change in pull request #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#discussion_r399123019
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -31,28 +31,45 @@ import { JobService } from 'services';
export class JobExceptionsComponent implements OnInit {
rootException = '';
listOfException: JobExceptionItemInterface[] = [];
+ truncated = false;
+ isLoading = false;
+ maxExceptions = 0;
trackExceptionBy(_: number, node: JobExceptionItemInterface) {
return node.timestamp;
}
-
- constructor(private jobService: JobService, private cdr: ChangeDetectorRef) {}
-
- ngOnInit() {
+ loadMore() {
+ this.isLoading = true;
+ this.maxExceptions += 10;
this.jobService.jobDetail$
.pipe(
distinctUntilChanged((pre, next) => pre.jid === next.jid),
- flatMap(job => this.jobService.loadExceptions(job.jid))
+ flatMap(job => this.jobService.loadExceptions(job.jid, this.maxExceptions))
)
- .subscribe(data => {
- // @ts-ignore
- if (data['root-exception']) {
- this.rootException = formatDate(data.timestamp, 'yyyy-MM-dd HH:mm:ss', 'en') + '\n' + data['root-exception'];
- } else {
- this.rootException = 'No Root Exception';
+ .subscribe(
+ data => {
+ // @ts-ignore
+ if (data['root-exception']) {
+ this.rootException =
+ formatDate(data.timestamp, 'yyyy-MM-dd HH:mm:ss', 'en') + '\n' + data['root-exception'];
+ } else {
+ this.rootException = 'No Root Exception';
+ }
+ this.truncated = data.truncated;
+ this.listOfException = data['all-exceptions'];
+ this.isLoading = false;
Review comment:
Makes sense. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #11436: [FLINK-11404][web] add load
more feature in exception page
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-603101658
I am reviewing this but it would be good if someone with more experience in TypeScript can give it another pass.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153874953",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6718",
"triggerID" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"triggerType" : "PUSH"
}, {
"hash" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155738739",
"triggerID" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 968f55dbffb11b37b7a1a12147c9dcf6374b015b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155738739) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] sorahn commented on a change in pull request #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
sorahn commented on a change in pull request #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#discussion_r397957146
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -31,28 +31,45 @@ import { JobService } from 'services';
export class JobExceptionsComponent implements OnInit {
rootException = '';
listOfException: JobExceptionItemInterface[] = [];
+ truncated = false;
+ isLoading = false;
+ maxExceptions = 0;
trackExceptionBy(_: number, node: JobExceptionItemInterface) {
return node.timestamp;
}
-
- constructor(private jobService: JobService, private cdr: ChangeDetectorRef) {}
-
- ngOnInit() {
+ loadMore() {
+ this.isLoading = true;
+ this.maxExceptions += 10;
this.jobService.jobDetail$
.pipe(
distinctUntilChanged((pre, next) => pre.jid === next.jid),
- flatMap(job => this.jobService.loadExceptions(job.jid))
+ flatMap(job => this.jobService.loadExceptions(job.jid, this.maxExceptions))
)
- .subscribe(data => {
- // @ts-ignore
- if (data['root-exception']) {
- this.rootException = formatDate(data.timestamp, 'yyyy-MM-dd HH:mm:ss', 'en') + '\n' + data['root-exception'];
- } else {
- this.rootException = 'No Root Exception';
+ .subscribe(
+ data => {
+ // @ts-ignore
+ if (data['root-exception']) {
+ this.rootException =
+ formatDate(data.timestamp, 'yyyy-MM-dd HH:mm:ss', 'en') + '\n' + data['root-exception'];
+ } else {
+ this.rootException = 'No Root Exception';
+ }
+ this.truncated = data.truncated;
+ this.listOfException = data['all-exceptions'];
+ this.isLoading = false;
Review comment:
is it worth moving the isLoading = false, and the cdr.markForCheck() into `finalize` from rxjs to avoid the repetition?
Looks good otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL commented on issue #11436: [FLINK-11404][web] add load
more feature in exception page
Posted by GitBox <gi...@apache.org>.
GJL commented on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-604901378
Merging.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153874953",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153874953) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153874953",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153874953) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153874953",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153874953) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354)
* 968f55dbffb11b37b7a1a12147c9dcf6374b015b UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "DELETED",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "DELETED",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153874953",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6718",
"triggerID" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"triggerType" : "PUSH"
}, {
"hash" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155738739",
"triggerID" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 968f55dbffb11b37b7a1a12147c9dcf6374b015b Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/155738739) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153874953",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/153874953) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] GJL closed pull request #11436: [FLINK-11404][web] add load
more feature in exception page
Posted by GitBox <gi...@apache.org>.
GJL closed pull request #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] vthinkxie commented on a change in pull request #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
vthinkxie commented on a change in pull request #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#discussion_r399027098
##########
File path: flink-runtime-web/web-dashboard/src/app/pages/job/exceptions/job-exceptions.component.ts
##########
@@ -31,28 +31,45 @@ import { JobService } from 'services';
export class JobExceptionsComponent implements OnInit {
rootException = '';
listOfException: JobExceptionItemInterface[] = [];
+ truncated = false;
+ isLoading = false;
+ maxExceptions = 0;
trackExceptionBy(_: number, node: JobExceptionItemInterface) {
return node.timestamp;
}
-
- constructor(private jobService: JobService, private cdr: ChangeDetectorRef) {}
-
- ngOnInit() {
+ loadMore() {
+ this.isLoading = true;
+ this.maxExceptions += 10;
this.jobService.jobDetail$
.pipe(
distinctUntilChanged((pre, next) => pre.jid === next.jid),
- flatMap(job => this.jobService.loadExceptions(job.jid))
+ flatMap(job => this.jobService.loadExceptions(job.jid, this.maxExceptions))
)
- .subscribe(data => {
- // @ts-ignore
- if (data['root-exception']) {
- this.rootException = formatDate(data.timestamp, 'yyyy-MM-dd HH:mm:ss', 'en') + '\n' + data['root-exception'];
- } else {
- this.rootException = 'No Root Exception';
+ .subscribe(
+ data => {
+ // @ts-ignore
+ if (data['root-exception']) {
+ this.rootException =
+ formatDate(data.timestamp, 'yyyy-MM-dd HH:mm:ss', 'en') + '\n' + data['root-exception'];
+ } else {
+ this.rootException = 'No Root Exception';
+ }
+ this.truncated = data.truncated;
+ this.listOfException = data['all-exceptions'];
+ this.isLoading = false;
Review comment:
thanks for your advice, use `tap` instead of `finalize` since the source never complete.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11436:
[FLINK-11404][web] add load more feature in exception page
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11436: [FLINK-11404][web] add load more feature in exception page
URL: https://github.com/apache/flink/pull/11436#issuecomment-600498156
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "FAILURE",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/153874953",
"triggerID" : "8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef",
"triggerType" : "PUSH"
}, {
"hash" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"status" : "PENDING",
"url" : "https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6718",
"triggerID" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"triggerType" : "PUSH"
}, {
"hash" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/155738739",
"triggerID" : "968f55dbffb11b37b7a1a12147c9dcf6374b015b",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8d4fa0649cb023f5ca7cd088f6b2d91bbda9dbef Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/153874953) Azure: [FAILURE](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6354)
* 968f55dbffb11b37b7a1a12147c9dcf6374b015b Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/155738739) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=6718)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services