[jira] [Commented] (CB-7045) improve plugman install (+spec)

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CB-7045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14046375#comment-14046375 ] 

ASF GitHub Bot commented on CB-7045:
------------------------------------

GitHub user jsoref opened a pull request:

    https://github.com/apache/cordova-lib/pull/46

    CB-7045 improve plugman install (+spec)

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jsoref/cordova-lib cb_7045

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/46.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #46
    
----
commit 864a2feb2bf806eb4dd35c94dc956ac67fe57922
Author: Josh Soref <js...@blackberry.com>
Date:   2014-06-27T20:39:36Z

    CB-7045 plugman.install.spec: shell.which depends on plugman.raw.fetch actually being called

commit 56276ef3e4d407bdd9c1212f5d75b267ede0530d
Author: Josh Soref <js...@blackberry.com>
Date:   2014-06-27T20:39:55Z

    CB-7045 plugman.install: engine.currentVersion should be a semver or null
    
    not ""

----


> improve plugman install (+spec)
> -------------------------------
>
>                 Key: CB-7045
>                 URL: https://issues.apache.org/jira/browse/CB-7045
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Plugman
>    Affects Versions: 3.5.0
>            Reporter: Josh Soref
>            Assignee: Josh Soref
>             Fix For: 3.6.0
>
>
> Currently install.spec skips some of its tests, i'd like more of them to work.
> {quote}
> function checkEngines(engines) {
> ...
>         if ( semver.satisfies(engine.currentVersion, engine.minVersion) || engine.currentVersion === null ) {
> {quote}
> this expects currentVersion to be a *number* or {{null}}, but currently it's possible for it to be {{""}}
> {{cleanVersionOutput}} will take {{""}} and return {{""}} which isn't helpful...
> {{callEngineScripts}} calls {{child_process.exec(scriptPath...}} and handles error, but not no output.



--
This message was sent by Atlassian JIRA
(v6.2#6252)