[jira] [Commented] (SLIDER-1133) Provide support to accept metainfo as a JSON blob from the command line

["Billie Rinaldi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SLIDER-1133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304363#comment-15304363 ] 

Billie Rinaldi commented on SLIDER-1133:
----------------------------------------

Gour, the patch looks fine to me.  I'm running the unit tests on the patch now, to double check.  The only thing I would suggest is that on the following line, you should specify the charset for getBytes (usually getBytes("UTF-8") or getBytes(Charset.forName("UTF-8")):
{noformat}
+        Files.write(buildInfo.appMetaInfoJson.getBytes(), destMetaInfo);
{noformat}

> Provide support to accept metainfo as a JSON blob from the command line
> -----------------------------------------------------------------------
>
>                 Key: SLIDER-1133
>                 URL: https://issues.apache.org/jira/browse/SLIDER-1133
>             Project: Slider
>          Issue Type: Bug
>          Components: client
>    Affects Versions: Slider 0.90.2
>            Reporter: Gour Saha
>            Assignee: Gour Saha
>         Attachments: SLIDER-1133-01.path
>
>
> Slider currently supports providing a file location containing JSON data on the command line. For advanced features required by SLIDER-906, we need to support accepting a JSON blob from the command line. This eliminates the need to create an intermediate file.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)