[GitHub] [hive] okumin commented on a change in pull request #2551: HIVE-25410: CommonMergeJoinOperator fails when a join key is ARRAY with arbitrary size

[GitBox <gi...@apache.org>]

okumin commented on a change in pull request #2551:
URL: https://github.com/apache/hive/pull/2551#discussion_r680135993



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/HiveStructComparator.java
##########
@@ -45,16 +48,14 @@ public int compare(Object key1, Object key2) {
         if (a1.size() == 0) {
             return 0;
         }
-        if (comparator == null) {

Review comment:
       The root cause is that the num of comparators is fixed to the size of the first List. This will work for STRUCT since the number of elements is consistent across records. However, in the case of ARRAY, it varies.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org