[GitHub] srkukarni opened a new pull request #3477: Fixed the behavior of Function start/stop

[GitBox <gi...@apache.org>]

srkukarni opened a new pull request #3477: Fixed the behavior of Function start/stop
URL: https://github.com/apache/pulsar/pull/3477
 
 
   ### Motivation
   The current behavior of function/source/sink start/stop functionality is really confusing. We just change the state of the function temporarily, i.e. we don't record the change of the functionstate anywhere. Thus if function workers die and come back up, they will restart stopped function instances. This pr fixes this behaviour. We record the state of each function instance in the function metadata, thus if function worker dies and comes back up, the function will still remain in the state that it was in before the death.
   ### Modifications
   
   Add a field in the FunctionMetaData proto to reflect the current state of the function instances.
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (yes / no)
     - The public API: (yes / no)
     - The schema: (yes / no / don't know)
     - The default values of configurations: (yes / no)
     - The wire protocol: (yes / no)
     - The rest endpoints: (yes / no)
     - The admin cli options: (yes / no)
     - Anything that affects deployment: (yes / no / don't know)
   
   ### Documentation
   
     - Does this pull request introduce a new feature? (yes / no)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
     - If a feature is not applicable for documentation, explain why?
     - If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services