You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/09/29 06:54:33 UTC

[GitHub] [incubator-dolphinscheduler] lgcareer commented on a change in pull request #3689: fix #3688, Optimization of table building statements

lgcareer commented on a change in pull request #3689:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/3689#discussion_r496457845



##########
File path: sql/dolphinscheduler_mysql.sql
##########
@@ -248,7 +248,7 @@ CREATE TABLE `QRTZ_TRIGGERS` (
   KEY `IDX_QRTZ_T_NFT_ST_MISFIRE` (`SCHED_NAME`,`MISFIRE_INSTR`,`NEXT_FIRE_TIME`,`TRIGGER_STATE`),
   KEY `IDX_QRTZ_T_NFT_ST_MISFIRE_GRP` (`SCHED_NAME`,`MISFIRE_INSTR`,`NEXT_FIRE_TIME`,`TRIGGER_GROUP`,`TRIGGER_STATE`),
   CONSTRAINT `QRTZ_TRIGGERS_ibfk_1` FOREIGN KEY (`SCHED_NAME`, `JOB_NAME`, `JOB_GROUP`) REFERENCES `QRTZ_JOB_DETAILS` (`SCHED_NAME`, `JOB_NAME`, `JOB_GROUP`)
-) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;

Review comment:
       Hi,we should discuss first,the utf8mb4 is suggested to use in mysql.You can see the article below.
   https://medium.com/@adamhooper/in-mysql-never-use-utf8-use-utf8mb4-11761243e434
   I saw the error you pointed `Index column size too large. The maximum column size is 767 bytes.`The another article give a method to resolve it.
   https://www.jianshu.com/p/5c0cce24189b




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org