[jira] [Commented] (MAPREDUCE-3325) Improvements to CapacityScheduler doc

["Hadoop QA (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MAPREDUCE-3325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142300#comment-13142300 ] 

Hadoop QA commented on MAPREDUCE-3325:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501980/MAPREDUCE-3325.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed unit tests in .

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1241//testReport/
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1241//console

This message is automatically generated.
                
> Improvements to CapacityScheduler doc
> -------------------------------------
>
>                 Key: MAPREDUCE-3325
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3325
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: mrv2
>    Affects Versions: 0.23.0
>            Reporter: Thomas Graves
>            Assignee: Thomas Graves
>         Attachments: MAPREDUCE-3325.patch
>
>
> I noticed the following issues with the capacity scheduler doc: ./hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-site/src/site/apt/CapacityScheduler.apt.vm
> - In overview section, 3rd paragraph,  sentence "There is an added benefit that an organization can access any excess capacity no being used by others".  No should be not. 
> - in overview section, 4th paragraph. dispropotionate misspelled 
> - in features section, under multitenancy - monopolizing is misspelled. 
> - in features section, under operability - it doesn't say if you can delete queues at runtime?  I see there is a note at the end but perhaps that can be added into the other sections to since its easy to miss that Note at the very end. 
> - in features section - hierarchy and Hierarchical mispelled. 
> - under configuration section the class to turn on to use capacity scheduler should be: org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityScheduler 
> - section on setting up queues, 4th sentence - hierarchy misspelled as heirarcy  and heirarchy. 
> - I think specifying how a user has to specify the queue when running a job/app would be useful information.  Especially with the new hierarchical queues.  Does the user have to specify the entire path like a.b.c or can they just specify c. 
> - under "Running and Pending Application Limits" section, property "yarn.scheduler.capacity.maximum-applications", they are referred to them as jobs, I believe that should be applications. 
> - misspelled concurrently as concurently in same section of maximum-applications. 
> - I think it should specify the defaults (if any) for the config vars.   Also what format are they specified in - int, float,etc? 
> - might be nice to say it doesn't support preemption. 
> - under admin options yarn.scheduler.capacity.<queue-path>.state - queues misspelled as queueus 
> - under changing queue configuration it should have "yarn" in front of the "rmadmin -refreshQueues". Similarly a few lines down at "$YARN_HOME/bin/rmadmin -refreshQueues"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira