You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/01/27 20:59:34 UTC

[GitHub] [trafficcontrol] ocket8888 commented on a change in pull request #5470: Adding atscfg overrides to insert the Release version in via string

ocket8888 commented on a change in pull request #5470:
URL: https://github.com/apache/trafficcontrol/pull/5470#discussion_r565629201



##########
File path: infrastructure/cdn-in-a-box/ort/traffic_ops_ort/__init__.py
##########
@@ -472,6 +472,14 @@ def main() -> int:
 	                    help="Sets the timeout in milliseconds for requests made to Traffic Ops.",
 	                    type=int,
 	                    default=None)
+	parser.add_argument("--via_string_release",

Review comment:
       Not that you need to bother updating ORT.py at all (bless you), but in most other places you call it `--via-string-release` - which I think is better, honestly - but here you have underscores instead of dashes.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org