[GitHub] [nifi] thenatog commented on a diff in pull request #6558: NIFI-9437 Flowfile Expiration cannot exceed 24 days

[GitBox <gi...@apache.org>]

thenatog commented on code in PR #6558:
URL: https://github.com/apache/nifi/pull/6558#discussion_r1002075729


##########
nifi-stateless/nifi-stateless-bundle/nifi-stateless-engine/src/main/java/org/apache/nifi/stateless/queue/StatelessFlowFileQueue.java:
##########
@@ -283,8 +283,8 @@ public String getFlowFileExpiration() {
     }
 
     @Override
-    public int getFlowFileExpiration(final TimeUnit timeUnit) {
-        return (int) timeUnit.convert(expirationMillis, TimeUnit.MILLISECONDS);
+    public long getFlowFileExpiration(final TimeUnit timeUnit) {
+        return timeUnit.convert(expirationMillis, TimeUnit.MILLISECONDS);

Review Comment:
   I believe a change also needs to be made to   _public void setFlowFileExpiration(final String flowExpirationPeriod)_, as the value on line 292 is still being cast to int. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org