You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by paul-rogers <gi...@git.apache.org> on 2016/12/07 18:35:23 UTC
[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...
GitHub user paul-rogers opened a pull request:
https://github.com/apache/drill/pull/683
DRILL-5114: Rationalize use of Logback logging in unit tests
Cleans up the Drill test Logback config files to reduce unnecessary
logging in tests and avoid Logback complaints about missing or
duplicate log config files.
Does not affect production logging.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paul-rogers/drill DRILL-5114
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/drill/pull/683.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #683
----
commit bbd5ceb4f1c61bfa844701d18220cbd019e1b700
Author: Paul Rogers <pr...@maprtech.com>
Date: 2016-12-07T18:33:48Z
DRILL-5114: Rationalize use of Logback logging in unit tests
Cleans up the Drill test Logback config files to reduce unnecessary
logging in tests and avoid Logback complaints about missing or
duplicate log config files.
Does not affect production logging.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...
Posted by chunhui-shi <gi...@git.apache.org>.
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/683#discussion_r92451306
--- Diff: logical/src/test/resources/logback-test.xml ---
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8" ?>
+<!-- Licensed to the Apache Software Foundation (ASF) under one or more contributor
+ license agreements. See the NOTICE file distributed with this work for additional
--- End diff --
The same question for this file. They look identical.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill issue #683: DRILL-5114: Rationalize use of Logback logging in unit tes...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers commented on the issue:
https://github.com/apache/drill/pull/683
Will fix later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...
Posted by chunhui-shi <gi...@git.apache.org>.
Github user chunhui-shi commented on a diff in the pull request:
https://github.com/apache/drill/pull/683#discussion_r92451193
--- Diff: exec/memory/base/src/test/resources/logback-test.xml ---
@@ -0,0 +1,42 @@
+<?xml version="1.0" encoding="UTF-8" ?>
--- End diff --
Why could not the test here use existing logback-test.xml?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] drill pull request #683: DRILL-5114: Rationalize use of Logback logging in u...
Posted by paul-rogers <gi...@git.apache.org>.
Github user paul-rogers closed the pull request at:
https://github.com/apache/drill/pull/683
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---