You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Neil Conway <ne...@gmail.com> on 2016/12/01 22:16:25 UTC
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/
-----------------------------------------------------------
(Updated Dec. 1, 2016, 10:16 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Rebase
Bugs: MESOS-6419
https://issues.apache.org/jira/browse/MESOS-6419
Repository: mesos
Description
-------
Previously, a newly added framework was assumed to always be
active. Adding inactive frameworks will be used to support recovered
frameworks that haven't yet re-registered.
Diffs (updated)
-----
include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
src/tests/slave_recovery_tests.cpp 3b7d8cf9600496d2e7f5105e4f561e914c54a36a
Diff: https://reviews.apache.org/r/53895/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/
-----------------------------------------------------------
(Updated Dec. 8, 2016, 1:03 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
updated "depends on" to have a single parent. -- @vinodkone
Bugs: MESOS-6419 and MESOS-6675
https://issues.apache.org/jira/browse/MESOS-6419
https://issues.apache.org/jira/browse/MESOS-6675
Repository: mesos
Description
-------
Previously, a newly added framework was assumed to always be
active. Adding inactive frameworks will be used to support recovered
frameworks that haven't yet re-registered.
Diffs
-----
CHANGELOG fe24e8e4291c76a015e1f344764ed53b653cd8cd
include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
src/master/master.cpp c2c08e176ba3b5afa15c5896b58b6545fb508f5b
src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
src/tests/slave_recovery_tests.cpp 324cf597b6aed7373d9018c4bc9de8fdeac0084c
Diff: https://reviews.apache.org/r/53895/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/
-----------------------------------------------------------
(Updated Dec. 7, 2016, 8:06 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Add dep
Bugs: MESOS-6419 and MESOS-6675
https://issues.apache.org/jira/browse/MESOS-6419
https://issues.apache.org/jira/browse/MESOS-6675
Repository: mesos
Description
-------
Previously, a newly added framework was assumed to always be
active. Adding inactive frameworks will be used to support recovered
frameworks that haven't yet re-registered.
Diffs
-----
CHANGELOG fe24e8e4291c76a015e1f344764ed53b653cd8cd
include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
src/master/master.cpp c2c08e176ba3b5afa15c5896b58b6545fb508f5b
src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
src/tests/slave_recovery_tests.cpp 324cf597b6aed7373d9018c4bc9de8fdeac0084c
Diff: https://reviews.apache.org/r/53895/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/#review158100
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Dec. 2, 2016, 9:50 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53895/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2016, 9:50 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6419 and MESOS-6675
> https://issues.apache.org/jira/browse/MESOS-6419
> https://issues.apache.org/jira/browse/MESOS-6675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, a newly added framework was assumed to always be
> active. Adding inactive frameworks will be used to support recovered
> frameworks that haven't yet re-registered.
>
>
> Diffs
> -----
>
> CHANGELOG fe24e8e4291c76a015e1f344764ed53b653cd8cd
> include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
> src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
> src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
> src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
> src/master/master.cpp c2c08e176ba3b5afa15c5896b58b6545fb508f5b
> src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
> src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
> src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
> src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
> src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
> src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
> src/tests/slave_recovery_tests.cpp 324cf597b6aed7373d9018c4bc9de8fdeac0084c
>
> Diff: https://reviews.apache.org/r/53895/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/
-----------------------------------------------------------
(Updated Dec. 2, 2016, 9:50 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Add CHANGELOG entry for allocator API change.
Bugs: MESOS-6419 and MESOS-6675
https://issues.apache.org/jira/browse/MESOS-6419
https://issues.apache.org/jira/browse/MESOS-6675
Repository: mesos
Description
-------
Previously, a newly added framework was assumed to always be
active. Adding inactive frameworks will be used to support recovered
frameworks that haven't yet re-registered.
Diffs (updated)
-----
CHANGELOG fe24e8e4291c76a015e1f344764ed53b653cd8cd
include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
src/master/master.cpp c2c08e176ba3b5afa15c5896b58b6545fb508f5b
src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
src/tests/slave_recovery_tests.cpp 324cf597b6aed7373d9018c4bc9de8fdeac0084c
Diff: https://reviews.apache.org/r/53895/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
Posted by Neil Conway <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/
-----------------------------------------------------------
(Updated Dec. 2, 2016, 9:47 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Add second JIRA.
Bugs: MESOS-6419 and MESOS-6675
https://issues.apache.org/jira/browse/MESOS-6419
https://issues.apache.org/jira/browse/MESOS-6675
Repository: mesos
Description
-------
Previously, a newly added framework was assumed to always be
active. Adding inactive frameworks will be used to support recovered
frameworks that haven't yet re-registered.
Diffs
-----
include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
src/tests/slave_recovery_tests.cpp 3b7d8cf9600496d2e7f5105e4f561e914c54a36a
Diff: https://reviews.apache.org/r/53895/diff/
Testing
-------
`make check`
Thanks,
Neil Conway
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
Posted by Neil Conway <ne...@gmail.com>.
> On Dec. 2, 2016, 9:42 p.m., Vinod Kone wrote:
> > Since allocator is modularized, can you add a blurb to CHANGELOG that it breaks the interface?
Done. I also create a new JIRA (MESOS-6675) for the allocator API change.
- Neil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/#review157831
-----------------------------------------------------------
On Dec. 2, 2016, 9:50 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53895/
> -----------------------------------------------------------
>
> (Updated Dec. 2, 2016, 9:50 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6419 and MESOS-6675
> https://issues.apache.org/jira/browse/MESOS-6419
> https://issues.apache.org/jira/browse/MESOS-6675
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, a newly added framework was assumed to always be
> active. Adding inactive frameworks will be used to support recovered
> frameworks that haven't yet re-registered.
>
>
> Diffs
> -----
>
> CHANGELOG fe24e8e4291c76a015e1f344764ed53b653cd8cd
> include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
> src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
> src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
> src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
> src/master/master.cpp c2c08e176ba3b5afa15c5896b58b6545fb508f5b
> src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
> src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
> src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
> src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
> src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
> src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
> src/tests/slave_recovery_tests.cpp 324cf597b6aed7373d9018c4bc9de8fdeac0084c
>
> Diff: https://reviews.apache.org/r/53895/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>
Re: Review Request 53895: Changed the allocator API to allow adding
inactive frameworks.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53895/#review157831
-----------------------------------------------------------
Since allocator is modularized, can you add a blurb to CHANGELOG that it breaks the interface?
- Vinod Kone
On Dec. 1, 2016, 10:16 p.m., Neil Conway wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53895/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2016, 10:16 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-6419
> https://issues.apache.org/jira/browse/MESOS-6419
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Previously, a newly added framework was assumed to always be
> active. Adding inactive frameworks will be used to support recovered
> frameworks that haven't yet re-registered.
>
>
> Diffs
> -----
>
> include/mesos/allocator/allocator.hpp 3fe04f8a4fb331defbe672c739df4e137bdb3627
> src/master/allocator/mesos/allocator.hpp 61159a91700270b1aa6fb335b8a41592e03ef8a9
> src/master/allocator/mesos/hierarchical.hpp 2c31471ee0f5d6836393bf87ff9ecfd8df835013
> src/master/allocator/mesos/hierarchical.cpp 3b759494071c4cae4b8b7dbcb0028df4146fc30e
> src/master/master.cpp e03a2e8025943825a2902102c43dc0eb66bacb6a
> src/tests/allocator.hpp bce11904f0b8de66a6620b636321568fdc0d113f
> src/tests/hierarchical_allocator_tests.cpp f9dcdbfff8823220409b05002418c98137a0696c
> src/tests/master_allocator_tests.cpp bb94e38d5bb472801366c172cfc036f2eecdcbcb
> src/tests/persistent_volume_endpoints_tests.cpp f35592ae311f499999d3e331fa78c8e427f34bf5
> src/tests/reservation_tests.cpp dddfbbe0fc3d0940a65a809ab8340d57dfc685c8
> src/tests/resource_offers_tests.cpp 3dde7bf236cb88d72dce73da18d3bc55f0f9402f
> src/tests/slave_recovery_tests.cpp 3b7d8cf9600496d2e7f5105e4f561e914c54a36a
>
> Diff: https://reviews.apache.org/r/53895/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Neil Conway
>
>