You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/09/11 16:10:29 UTC
[GitHub] [skywalking] xbkaishui opened a new pull request #5474: Alarm support Wechat webhook
xbkaishui opened a new pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bug fix
- [√ ] New feature provided
- [ ] Improve performance
- Related issues
resolve #5460
___
### Bug fix
- Bug description.
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
Alarm support Wechat webhook
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `19.89%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 32.46% -19.90%
+ Complexity 3362 2051 -1311
=============================================
Files 899 875 -24
Lines 22111 21385 -726
Branches 2116 2051 -65
=============================================
- Hits 11578 6943 -4635
- Misses 9608 13901 +4293
+ Partials 925 541 -384
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [309 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 174 -725
Lines 22111 4136 -17975
Branches 2116 477 -1639
============================================
- Hits 11578 0 -11578
+ Misses 9608 4136 -5472
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.81%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.54% -0.82%
+ Complexity 3362 3307 -55
============================================
Files 899 896 -3
Lines 22111 22018 -93
Branches 2116 2107 -9
============================================
- Hits 11578 11350 -228
- Misses 9608 9746 +138
+ Partials 925 922 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [44 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `5.65%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 46.71% -5.66%
+ Complexity 3362 3070 -292
============================================
Files 899 898 -1
Lines 22111 22067 -44
Branches 2116 2102 -14
============================================
- Hits 11578 10308 -1270
- Misses 9608 10893 +1285
+ Partials 925 866 -59
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.56%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.79% -0.57%
+ Complexity 3362 3322 -40
============================================
Files 899 896 -3
Lines 22111 22018 -93
Branches 2116 2107 -9
============================================
- Hits 11578 11404 -174
- Misses 9608 9688 +80
- Partials 925 926 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 161 -738
Lines 22111 3887 -18224
Branches 2116 457 -1659
============================================
- Hits 11578 0 -11578
+ Misses 9608 3887 -5721
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [866 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 177 -722
Lines 22111 4205 -17906
Branches 2116 484 -1632
============================================
- Hits 11578 0 -11578
+ Misses 9608 4205 -5403
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `22.07%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.18% 30.11% -22.08%
+ Complexity 3352 1961 -1391
=============================================
Files 898 875 -23
Lines 22099 21428 -671
Branches 2116 2052 -64
=============================================
- Hits 11533 6453 -5080
- Misses 9639 14487 +4848
+ Partials 927 488 -439
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [315 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `22.75%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.18% 29.43% -22.76%
+ Complexity 3352 1899 -1453
=============================================
Files 898 875 -23
Lines 22099 21385 -714
Branches 2116 2049 -67
=============================================
- Hits 11533 6294 -5239
- Misses 9639 14613 +4974
+ Partials 927 478 -449
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [326 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.23%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.13% -0.24%
+ Complexity 3362 3352 -10
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11552 -26
- Misses 9608 9680 +72
- Partials 925 927 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691424534
Yeap, one minute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.46%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.89% -1.47%
+ Complexity 3362 3286 -76
============================================
Files 899 896 -3
Lines 22111 22008 -103
Branches 2116 2106 -10
============================================
- Hits 11578 11202 -376
- Misses 9608 9898 +290
+ Partials 925 908 -17
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.97%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.38% -0.98%
+ Complexity 3362 3324 -38
============================================
Files 899 897 -2
Lines 22111 22125 +14
Branches 2116 2104 -12
============================================
- Hits 11578 11369 -209
- Misses 9608 9840 +232
+ Partials 925 916 -9
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...r/storage/plugin/influxdb/query/TopologyQuery.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9Ub3BvbG9neVF1ZXJ5LmphdmE=) | `3.50% <0.00%> (-59.65%)` | `2.00% <0.00%> (-12.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.24%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.12% -0.25%
+ Complexity 3362 3352 -10
============================================
Files 899 901 +2
Lines 22111 22163 +52
Branches 2116 2119 +3
============================================
- Hits 11578 11552 -26
- Misses 9608 9684 +76
- Partials 925 927 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `19.26%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 33.09% -19.27%
+ Complexity 3362 2122 -1240
=============================================
Files 899 878 -21
Lines 22111 21527 -584
Branches 2116 2063 -53
=============================================
- Hits 11578 7124 -4454
- Misses 9608 13852 +4244
+ Partials 925 551 -374
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 162 -737
Lines 22111 3897 -18214
Branches 2116 450 -1666
============================================
- Hits 11578 0 -11578
+ Misses 9608 3897 -5711
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [866 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 162 -737
Lines 22111 3905 -18206
Branches 2116 450 -1666
============================================
- Hits 11578 0 -11578
+ Misses 9608 3905 -5703
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [865 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691423745
> What is this? This doesn't like the alarm message we sent.
this is just a test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.85%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.51% -2.86%
+ Complexity 3362 3199 -163
============================================
Files 899 894 -5
Lines 22111 22051 -60
Branches 2116 2102 -14
============================================
- Hits 11578 10918 -660
- Misses 9608 10241 +633
+ Partials 925 892 -33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [54 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487359648
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691398937
@kezhenxu94 We had a discussion here, https://github.com/apache/skywalking/issues/5460. Please take a look.
From my personal preference, I don't like the integration API in the same method. Because they belong to different enterprises. They definitely will not consider others' API, if they are going to upgrade one day.
Such as, they could request a header or different authentication way.
If one day, something is not incompatible, we have to add strange `if/else`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `7.14%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 45.22% -7.15%
+ Complexity 3362 3051 -311
============================================
Files 899 898 -1
Lines 22111 22103 -8
Branches 2116 2117 +1
============================================
- Hits 11578 9995 -1583
- Misses 9608 11286 +1678
+ Partials 925 822 -103
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [87 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `14.03%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 38.32% -14.04%
+ Complexity 3362 2430 -932
=============================================
Files 899 898 -1
Lines 22111 22078 -33
Branches 2116 2117 +1
=============================================
- Hits 11578 8461 -3117
- Misses 9608 12988 +3380
+ Partials 925 629 -296
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [204 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `17.47%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.18% 34.71% -17.48%
+ Complexity 3352 2210 -1142
=============================================
Files 898 875 -23
Lines 22099 21479 -620
Branches 2116 2059 -57
=============================================
- Hits 11533 7456 -4077
- Misses 9639 13478 +3839
+ Partials 927 545 -382
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [254 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.21%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.15% -0.22%
+ Complexity 3362 3356 -6
============================================
Files 899 897 -2
Lines 22111 22133 +22
Branches 2116 2119 +3
============================================
- Hits 11578 11543 -35
- Misses 9608 9662 +54
- Partials 925 928 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [13 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `14.42%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 37.93% -14.43%
+ Complexity 3362 2372 -990
=============================================
Files 899 880 -19
Lines 22111 21612 -499
Branches 2116 2070 -46
=============================================
- Hits 11578 8199 -3379
- Misses 9608 12798 +3190
+ Partials 925 615 -310
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [223 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 161 -738
Lines 22111 3886 -18225
Branches 2116 443 -1673
============================================
- Hits 11578 0 -11578
+ Misses 9608 3886 -5722
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [867 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487373632
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.75%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.60% -2.76%
+ Complexity 3362 3199 -163
============================================
Files 899 892 -7
Lines 22111 22009 -102
Branches 2116 2098 -18
============================================
- Hits 11578 10918 -660
- Misses 9608 10199 +591
+ Partials 925 892 -33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [56 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `3.18%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.18% -3.19%
+ Complexity 3362 3226 -136
============================================
Files 899 897 -2
Lines 22111 22074 -37
Branches 2116 2101 -15
============================================
- Hits 11578 10856 -722
- Misses 9608 10331 +723
+ Partials 925 887 -38
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchInsertRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaEluc2VydFJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...torage/plugin/elasticsearch/base/StorageEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9TdG9yYWdlRXNEQU8uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [63 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `4.31%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 48.05% -4.32%
+ Complexity 3362 3174 -188
============================================
Files 899 898 -1
Lines 22111 22122 +11
Branches 2116 2117 +1
============================================
- Hits 11578 10630 -948
- Misses 9608 10610 +1002
+ Partials 925 882 -43
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [56 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.19%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.16% -0.20%
+ Complexity 3362 3355 -7
============================================
Files 899 897 -2
Lines 22111 22125 +14
Branches 2116 2104 -12
============================================
- Hits 11578 11542 -36
- Misses 9608 9654 +46
- Partials 925 929 +4
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 177 -721
Lines 22099 4116 -17983
Branches 2116 473 -1643
============================================
- Hits 11533 0 -11533
+ Misses 9639 4116 -5523
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487360304
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `19.28%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 33.07% -19.29%
+ Complexity 3362 2122 -1240
=============================================
Files 899 880 -19
Lines 22111 21538 -573
Branches 2116 2063 -53
=============================================
- Hits 11578 7124 -4454
- Misses 9608 13863 +4255
+ Partials 925 551 -374
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [286 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `3.02%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.33% -3.03%
+ Complexity 3362 3186 -176
============================================
Files 899 892 -7
Lines 22111 22009 -102
Branches 2116 2098 -18
============================================
- Hits 11578 10858 -720
- Misses 9608 10263 +655
+ Partials 925 888 -37
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [58 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `38.95%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 38.95% 0.00% -38.96%
============================================
Files 897 175 -722
Lines 22069 4163 -17906
Branches 2115 480 -1635
============================================
- Hits 8597 0 -8597
+ Misses 12848 4163 -8685
+ Partials 624 0 -624
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-74.29%)` | `0.00% <0.00%> (-7.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | `0.00% <0.00%> (-8.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [719 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691425249
Do you have a twitter account? Could you share your name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 174 -725
Lines 22111 4106 -18005
Branches 2116 473 -1643
============================================
- Hits 11578 0 -11578
+ Misses 9608 4106 -5502
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487362181
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.58%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.77% -1.59%
+ Complexity 3362 3301 -61
============================================
Files 899 898 -1
Lines 22111 22131 +20
Branches 2116 2118 +2
============================================
- Hits 11578 11237 -341
- Misses 9608 9972 +364
+ Partials 925 922 -3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [28 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 163 -735
Lines 22099 3871 -18228
Branches 2116 447 -1669
============================================
- Hits 11533 0 -11533
+ Misses 9639 3871 -5768
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [863 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487374549
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 164 -734
Lines 22099 3900 -18199
Branches 2116 444 -1672
============================================
- Hits 11533 0 -11533
+ Misses 9639 3900 -5739
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [866 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487372245
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.20% +0.01%
+ Complexity 3352 3351 -1
============================================
Files 898 899 +1
Lines 22099 22120 +21
Branches 2116 2118 +2
============================================
+ Hits 11533 11548 +15
- Misses 9639 9645 +6
Partials 927 927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `51.66% <0.00%> (-3.34%)` | `14.00% <0.00%> (-2.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `20.90%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 31.45% -20.91%
+ Complexity 3362 2145 -1217
=============================================
Files 899 866 -33
Lines 22111 20991 -1120
Branches 2116 1969 -147
=============================================
- Hits 11578 6603 -4975
- Misses 9608 13818 +4210
+ Partials 925 570 -355
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `82.47% <100.00%> (-15.45%)` | `15.00 <0.00> (-2.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [305 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.53%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.82% -1.54%
+ Complexity 3362 3299 -63
============================================
Files 899 896 -3
Lines 22111 22086 -25
Branches 2116 2103 -13
============================================
- Hits 11578 11226 -352
- Misses 9608 9947 +339
+ Partials 925 913 -12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.20% +0.01%
+ Complexity 3352 3351 -1
============================================
Files 898 899 +1
Lines 22099 22120 +21
Branches 2116 2118 +2
============================================
+ Hits 11533 11548 +15
- Misses 9639 9645 +6
Partials 927 927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `51.66% <0.00%> (-3.34%)` | `14.00% <0.00%> (-2.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `9.12%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 43.24% -9.13%
+ Complexity 3362 2923 -439
============================================
Files 899 898 -1
Lines 22111 22066 -45
Branches 2116 2116
============================================
- Hits 11578 9542 -2036
- Misses 9608 11722 +2114
+ Partials 925 802 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [120 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.91%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.45% -0.92%
+ Complexity 3362 3324 -38
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11401 -177
- Misses 9608 9831 +223
- Partials 925 927 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [18 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691401665
> A minor different of slack vs wechat(dingtalk) is slack support batch message, wechat and dingtalk only support single message
This is a kind of thing, I want to avoid. If we use a template, this will be strange to separate in the codes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.17% 0.00% -52.18%
============================================
Files 897 175 -722
Lines 22105 4163 -17942
Branches 2116 480 -1636
============================================
- Hits 11534 0 -11534
+ Misses 9648 4163 -5485
+ Partials 923 0 -923
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `14.90%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 37.45% -14.91%
+ Complexity 3362 2408 -954
=============================================
Files 899 893 -6
Lines 22111 21967 -144
Branches 2116 2084 -32
=============================================
- Hits 11578 8228 -3350
- Misses 9608 13125 +3517
+ Partials 925 614 -311
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [230 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487373407
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487359648
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.38%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.97% -2.39%
+ Complexity 3362 3263 -99
============================================
Files 899 897 -2
Lines 22111 22074 -37
Branches 2116 2101 -15
============================================
- Hits 11578 11032 -546
- Misses 9608 10138 +530
+ Partials 925 904 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.45% <0.00%> (-79.00%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [55 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.41%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.95% -2.42%
+ Complexity 3362 3263 -99
============================================
Files 899 899
Lines 22111 22085 -26
Branches 2116 2101 -15
============================================
- Hits 11578 11032 -546
- Misses 9608 10149 +541
+ Partials 925 904 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.45% <0.00%> (-79.00%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [53 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 175 -723
Lines 22099 4110 -17989
Branches 2116 473 -1643
============================================
- Hits 11533 0 -11533
+ Misses 9639 4110 -5529
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [855 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487385177
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 171 -728
Lines 22111 4050 -18061
Branches 2116 459 -1657
============================================
- Hits 11578 0 -11578
+ Misses 9608 4050 -5558
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [861 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487362857
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.83%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.52% -0.84%
+ Complexity 3362 3333 -29
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11418 -160
- Misses 9608 9815 +207
- Partials 925 926 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.90%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.45% -0.91%
+ Complexity 3362 3321 -41
============================================
Files 899 900 +1
Lines 22111 22156 +45
Branches 2116 2119 +3
============================================
- Hits 11578 11401 -177
- Misses 9608 9831 +223
+ Partials 925 924 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [26 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 164 -735
Lines 22111 3930 -18181
Branches 2116 447 -1669
============================================
- Hits 11578 0 -11578
+ Misses 9608 3930 -5678
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.13% -0.23%
+ Complexity 3362 3356 -6
============================================
Files 899 899
Lines 22111 22139 +28
Branches 2116 2119 +3
============================================
- Hits 11578 11543 -35
- Misses 9608 9668 +60
- Partials 925 928 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [11 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 177 172 -5
Lines 4205 4070 -135
Branches 484 463 -21
=======================================
+ Misses 4205 4070 -135
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487359687
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `22.23%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 30.12% -22.24%
+ Complexity 3362 1951 -1411
=============================================
Files 899 879 -20
Lines 22111 21515 -596
Branches 2116 2048 -68
=============================================
- Hits 11578 6481 -5097
- Misses 9608 14562 +4954
+ Partials 925 472 -453
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [321 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487362181
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.62%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.73% -1.63%
+ Complexity 3362 3299 -63
============================================
Files 899 897 -2
Lines 22111 22125 +14
Branches 2116 2104 -12
============================================
- Hits 11578 11226 -352
- Misses 9608 9986 +378
+ Partials 925 913 -12
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [.../plugin/jdbc/h2/dao/H2UITemplateManagementDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVUlUZW1wbGF0ZU1hbmFnZW1lbnREQU8uamF2YQ==) | `2.43% <0.00%> (-65.86%)` | `1.00% <0.00%> (-7.00%)` | |
| [...elasticsearch/query/UITemplateManagementEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvVUlUZW1wbGF0ZU1hbmFnZW1lbnRFc0RBTy5qYXZh) | `6.12% <0.00%> (-65.31%)` | `2.00% <0.00%> (-5.00%)` | |
| ... and [35 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `3.62%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 48.73% -3.63%
+ Complexity 3362 3160 -202
============================================
Files 899 891 -8
Lines 22111 21927 -184
Branches 2116 2080 -36
============================================
- Hits 11578 10686 -892
- Misses 9608 10374 +766
+ Partials 925 867 -58
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [66 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.85%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.50% -1.86%
+ Complexity 3362 3289 -73
============================================
Files 899 900 +1
Lines 22111 22149 +38
Branches 2116 2118 +2
============================================
- Hits 11578 11186 -392
- Misses 9608 10059 +451
+ Partials 925 904 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `11.45%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 40.91% -11.46%
+ Complexity 3362 2586 -776
=============================================
Files 899 897 -2
Lines 22111 22111
Branches 2116 2118 +2
=============================================
- Hits 11578 9046 -2532
- Misses 9608 12390 +2782
+ Partials 925 675 -250
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [184 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 174 -725
Lines 22111 4106 -18005
Branches 2116 473 -1643
============================================
- Hits 11578 0 -11578
+ Misses 9608 4106 -5502
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...7bb7448](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `23.07%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 29.28% -23.08%
+ Complexity 3362 1897 -1465
=============================================
Files 899 878 -21
Lines 22111 21478 -633
Branches 2116 2047 -69
=============================================
- Hits 11578 6290 -5288
- Misses 9608 14708 +5100
+ Partials 925 480 -445
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [335 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `14.06%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 38.29% -14.07%
+ Complexity 3362 2463 -899
=============================================
Files 899 895 -4
Lines 22111 21973 -138
Branches 2116 2084 -32
=============================================
- Hits 11578 8415 -3163
- Misses 9608 12942 +3334
+ Partials 925 616 -309
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [213 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691422711
<img width="1145" alt="屏幕快照 2020-09-12 下午2 13 33" src="https://user-images.githubusercontent.com/1477791/92988907-6adf9a00-f502-11ea-9ccd-2d1777c7ac2d.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 169 -730
Lines 22111 4016 -18095
Branches 2116 455 -1661
============================================
- Hits 11578 0 -11578
+ Misses 9608 4016 -5592
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [862 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.87%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.48% -1.88%
+ Complexity 3362 3253 -109
============================================
Files 899 896 -3
Lines 22111 21970 -141
Branches 2116 2101 -15
============================================
- Hits 11578 11092 -486
- Misses 9608 9976 +368
+ Partials 925 902 -23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [59 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `17.27%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 35.08% -17.28%
+ Complexity 3362 2227 -1135
=============================================
Files 899 876 -23
Lines 22111 21468 -643
Branches 2116 2036 -80
=============================================
- Hits 11578 7533 -4045
- Misses 9608 13367 +3759
+ Partials 925 568 -357
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [264 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `21.31%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 31.05% -21.32%
+ Complexity 3362 2195 -1167
=============================================
Files 899 897 -2
Lines 22111 21834 -277
Branches 2116 2065 -51
=============================================
- Hits 11578 6780 -4798
- Misses 9608 14475 +4867
+ Partials 925 579 -346
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `82.47% <100.00%> (-15.45%)` | `15.00 <0.00> (-2.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [269 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 177 -721
Lines 22099 4116 -17983
Branches 2116 473 -1643
============================================
- Hits 11533 0 -11533
+ Misses 9639 4116 -5523
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `4.94%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 47.41% -4.95%
+ Complexity 3362 3104 -258
============================================
Files 899 898 -1
Lines 22111 22070 -41
Branches 2116 2102 -14
============================================
- Hits 11578 10465 -1113
- Misses 9608 10737 +1129
+ Partials 925 868 -57
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [71 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `22.58%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 29.77% -22.59%
+ Complexity 3362 1932 -1430
=============================================
Files 899 879 -20
Lines 22111 21515 -596
Branches 2116 2048 -68
=============================================
- Hits 11578 6407 -5171
- Misses 9608 14636 +5028
+ Partials 925 472 -453
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [329 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 175 -724
Lines 22111 4163 -17948
Branches 2116 480 -1636
============================================
- Hits 11578 0 -11578
+ Misses 9608 4163 -5445
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `3.68%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 48.67% -3.69%
+ Complexity 3362 3203 -159
============================================
Files 899 898 -1
Lines 22111 22112 +1
Branches 2116 2118 +2
============================================
- Hits 11578 10763 -815
- Misses 9608 10465 +857
+ Partials 925 884 -41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [51 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.67%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.69% -1.68%
+ Complexity 3362 3301 -61
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11233 -345
- Misses 9608 10020 +412
+ Partials 925 906 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691423272
What is this? This doesn't like the alarm message we sent.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.87%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.48% -2.88%
+ Complexity 3362 3199 -163
============================================
Files 899 896 -3
Lines 22111 22062 -49
Branches 2116 2102 -14
============================================
- Hits 11578 10918 -660
- Misses 9608 10252 +644
+ Partials 925 892 -33
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `6.34%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 46.02% -6.35%
+ Complexity 3362 3019 -343
============================================
Files 899 897 -2
Lines 22111 22000 -111
Branches 2116 2096 -20
============================================
- Hits 11578 10125 -1453
- Misses 9608 11016 +1408
+ Partials 925 859 -66
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [103 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.18%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.17% -2.19%
+ Complexity 3362 3241 -121
============================================
Files 899 896 -3
Lines 22111 22062 -49
Branches 2116 2102 -14
============================================
- Hits 11578 11070 -508
- Misses 9608 10090 +482
+ Partials 925 902 -23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| [...receiver/meter/provider/MeterReceiverProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWV0ZXItcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvbWV0ZXIvcHJvdmlkZXIvTWV0ZXJSZWNlaXZlclByb3ZpZGVyLmphdmE=) | `18.75% <0.00%> (-81.25%)` | `3.00% <0.00%> (-5.00%)` | |
| ... and [46 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.58% -1.78%
+ Complexity 3362 727 -2635
============================================
Files 899 178 -721
Lines 22111 4244 -17867
Branches 2116 485 -1631
============================================
- Hits 11578 2147 -9431
+ Misses 9608 1834 -7774
+ Partials 925 263 -662
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | | | |
| [.../skywalking/oap/server/core/analysis/NodeType.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvTm9kZVR5cGUuamF2YQ==) | | | |
| [...ap/server/core/metric/promethues/rule/Relabel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWV0cmljL3Byb21ldGh1ZXMvcnVsZS9SZWxhYmVsLmphdmE=) | | | |
| [.../server/receiver/profile/module/ProfileModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcHJvZmlsZS1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9wcm9maWxlL21vZHVsZS9Qcm9maWxlTW9kdWxlLmphdmE=) | | | |
| [...arch/ZipkinStorageModuleElasticsearchProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS16aXBraW4tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvc3RvcmFnZS9wbHVnaW4vemlwa2luL2VsYXN0aWNzZWFyY2gvWmlwa2luU3RvcmFnZU1vZHVsZUVsYXN0aWNzZWFyY2hQcm92aWRlci5qYXZh) | | | |
| [.../core/mock/MockComponentLibraryCatalogService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItdG9vbHMvcHJvZmlsZS1leHBvcnRlci90b29sLXByb2ZpbGUtc25hcHNob3Qtc2VydmVyLW1vY2svc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci90b29sL3Byb2ZpbGUvY29yZS9tb2NrL01vY2tDb21wb25lbnRMaWJyYXJ5Q2F0YWxvZ1NlcnZpY2UuamF2YQ==) | | | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691403960
Yes, for now I totally agree @wu-sheng 's thought, we can't control the outside dependency change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487359776
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `15.59%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 36.76% -15.60%
+ Complexity 3362 2358 -1004
=============================================
Files 899 898 -1
Lines 22111 22056 -55
Branches 2116 2116
=============================================
- Hits 11578 8109 -3469
- Misses 9608 13336 +3728
+ Partials 925 611 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [234 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `31.18%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 21.17% -31.19%
+ Complexity 3362 1457 -1905
=============================================
Files 899 877 -22
Lines 22111 21291 -820
Branches 2116 2017 -99
=============================================
- Hits 11578 4508 -7070
- Misses 9608 16459 +6851
+ Partials 925 324 -601
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `82.47% <100.00%> (-15.45%)` | `15.00 <0.00> (-2.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [430 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `16.74%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 35.62% -16.75%
+ Complexity 3362 2225 -1137
=============================================
Files 899 870 -29
Lines 22111 21375 -736
Branches 2116 2026 -90
=============================================
- Hits 11578 7614 -3964
- Misses 9608 13201 +3593
+ Partials 925 560 -365
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [262 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.76%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.59% -2.77%
+ Complexity 3362 3253 -109
============================================
Files 899 898 -1
Lines 22111 22139 +28
Branches 2116 2118 +2
============================================
- Hits 11578 10980 -598
- Misses 9608 10270 +662
+ Partials 925 889 -36
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...in/elasticsearch/base/TimeRangeIndexNameMaker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9UaW1lUmFuZ2VJbmRleE5hbWVNYWtlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ticsearch7/client/ElasticSearch7UpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9jbGllbnQvRWxhc3RpY1NlYXJjaDdVcGRhdGVSZXF1ZXN0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **increase** coverage by `0.29%`.
> The diff coverage is `62.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.36% 52.65% +0.29%
+ Complexity 3362 3361 -1
============================================
Files 899 1590 +691
Lines 22111 33881 +11770
Branches 2116 3689 +1573
============================================
+ Hits 11578 17840 +6262
- Misses 9608 15188 +5580
+ Partials 925 853 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/wechat/WechatSettings.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0U2V0dGluZ3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `67.53% <10.00%> (+13.90%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `94.28% <100.00%> (+29.57%)` | `6.00 <0.00> (ø)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1085 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691399820
A minor different of slack vs wechat(dingtalk) is slack support batch message, wechat and dingtalk only support single message
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.18%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.17% -0.19%
+ Complexity 3362 3357 -5
============================================
Files 899 898 -1
Lines 22111 22148 +37
Branches 2116 2119 +3
============================================
- Hits 11578 11556 -22
- Misses 9608 9665 +57
- Partials 925 927 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [9 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `21.55%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.18% 30.63% -21.56%
+ Complexity 3352 1994 -1358
=============================================
Files 898 875 -23
Lines 22099 21456 -643
Branches 2116 2057 -59
=============================================
- Hits 11533 6572 -4961
- Misses 9639 14392 +4753
+ Partials 927 492 -435
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [306 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 163 -736
Lines 22111 3871 -18240
Branches 2116 447 -1669
============================================
- Hits 11578 0 -11578
+ Misses 9608 3871 -5737
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...345c120](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `9.69%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 42.67% -9.70%
+ Complexity 3362 2883 -479
============================================
Files 899 898 -1
Lines 22111 22038 -73
Branches 2116 2111 -5
============================================
- Hits 11578 9404 -2174
- Misses 9608 11839 +2231
+ Partials 925 795 -130
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [133 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487385197
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `9.70%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 42.66% -9.71%
+ Complexity 3362 2882 -480
============================================
Files 899 898 -1
Lines 22111 22038 -73
Branches 2116 2111 -5
============================================
- Hits 11578 9402 -2176
- Misses 9608 11840 +2232
+ Partials 925 796 -129
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [134 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `6.04%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 46.31% -6.05%
+ Complexity 3362 3040 -322
============================================
Files 899 898 -1
Lines 22111 22039 -72
Branches 2116 2097 -19
============================================
- Hits 11578 10208 -1370
- Misses 9608 10971 +1363
+ Partials 925 860 -65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [94 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `15.41%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 36.95% -15.42%
+ Complexity 3362 2346 -1016
=============================================
Files 899 895 -4
Lines 22111 21994 -117
Branches 2116 2096 -20
=============================================
- Hits 11578 8127 -3451
- Misses 9608 13246 +3638
+ Partials 925 621 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [244 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487362181
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `15.38%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 36.97% -15.39%
+ Complexity 3362 2287 -1075
=============================================
Files 899 870 -29
Lines 22111 21383 -728
Branches 2116 2026 -90
=============================================
- Hits 11578 7907 -3671
- Misses 9608 12913 +3305
+ Partials 925 563 -362
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [249 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.65%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.70% -1.66%
+ Complexity 3362 3301 -61
============================================
Files 899 898 -1
Lines 22111 22153 +42
Branches 2116 2119 +3
============================================
- Hits 11578 11233 -345
- Misses 9608 10014 +406
+ Partials 925 906 -19
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...in/influxdb/query/UITemplateManagementDAOImpl.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9xdWVyeS9VSVRlbXBsYXRlTWFuYWdlbWVudERBT0ltcGwuamF2YQ==) | `1.75% <0.00%> (-85.97%)` | `1.00% <0.00%> (-6.00%)` | |
| ... and [23 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/e99d6bdc8e579dc91a5fd46a738ae56b28837359?el=desc) will **decrease** coverage by `0.09%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.30% 52.20% -0.10%
- Complexity 3303 3351 +48
============================================
Files 1587 899 -688
Lines 33786 22120 -11666
Branches 3700 2118 -1582
============================================
- Hits 17672 11548 -6124
+ Misses 15264 9645 -5619
- Partials 850 927 +77
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-31.27%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-24.57%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...p/server/core/analysis/metrics/MinLongMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9NaW5Mb25nTWV0cmljcy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...er/exporter/provider/grpc/GRPCExporterSetting.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9leHBvcnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2V4cG9ydGVyL3Byb3ZpZGVyL2dycGMvR1JQQ0V4cG9ydGVyU2V0dGluZy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...ent/core/plugin/bytebuddy/ReturnTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9SZXR1cm5UeXBlTmFtZU1hdGNoLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (ø%)` | |
| ... and [1092 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `62.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.36% 52.57% +0.20%
+ Complexity 3362 3352 -10
============================================
Files 899 1591 +692
Lines 22111 33922 +11811
Branches 2116 3687 +1571
============================================
+ Hits 11578 17833 +6255
- Misses 9608 15236 +5628
+ Partials 925 853 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/wechat/WechatSettings.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0U2V0dGluZ3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `67.53% <10.00%> (+13.90%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `94.28% <100.00%> (+29.57%)` | `6.00 <0.00> (ø)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1082 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui removed a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui removed a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691422711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.83%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.52% -0.84%
+ Complexity 3362 3333 -29
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11418 -160
- Misses 9608 9815 +207
- Partials 925 926 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...a7403d8](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `7.82%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 44.53% -7.83%
+ Complexity 3362 3010 -352
============================================
Files 899 898 -1
Lines 22111 22103 -8
Branches 2116 2117 +1
============================================
- Hits 11578 9844 -1734
- Misses 9608 11447 +1839
+ Partials 925 812 -113
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [93 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `7.06%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 45.29% -7.07%
+ Complexity 3362 3058 -304
============================================
Files 899 898 -1
Lines 22111 22103 -8
Branches 2116 2117 +1
============================================
- Hits 11578 10012 -1566
- Misses 9608 11270 +1662
+ Partials 925 821 -104
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [84 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `14.80%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 37.55% -14.81%
+ Complexity 3362 2405 -957
=============================================
Files 899 898 -1
Lines 22111 22068 -43
Branches 2116 2116
=============================================
- Hits 11578 8288 -3290
- Misses 9608 13169 +3561
+ Partials 925 611 -314
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [211 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.09% -0.27%
+ Complexity 3362 3346 -16
============================================
Files 899 898 -1
Lines 22111 22148 +37
Branches 2116 2119 +3
============================================
- Hits 11578 11538 -40
- Misses 9608 9685 +77
Partials 925 925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.02%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.33% -1.03%
+ Complexity 3362 3324 -38
============================================
Files 899 900 +1
Lines 22111 22149 +38
Branches 2116 2118 +2
============================================
- Hits 11578 11371 -207
- Misses 9608 9868 +260
+ Partials 925 910 -15
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| [...ap/server/core/storage/ttl/DataTTLKeeperTimer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS90dGwvRGF0YVRUTEtlZXBlclRpbWVyLmphdmE=) | `29.03% <0.00%> (-48.39%)` | `2.00% <0.00%> (-4.00%)` | |
| [...storage/plugin/influxdb/base/HistoryDeleteDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1pbmZsdXhkYi1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9pbmZsdXhkYi9iYXNlL0hpc3RvcnlEZWxldGVEQU8uamF2YQ==) | `33.33% <0.00%> (-33.34%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `34.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 34.37% 0.00% -34.38%
============================================
Files 878 173 -705
Lines 21546 4081 -17465
Branches 2066 463 -1603
============================================
- Hits 7407 0 -7407
+ Misses 13577 4081 -9496
+ Partials 562 0 -562
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-74.29%)` | `0.00% <0.00%> (-7.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | `0.00% <0.00%> (-8.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [702 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `16.89%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 35.46% -16.90%
+ Complexity 3362 2203 -1159
=============================================
Files 899 877 -22
Lines 22111 21424 -687
Branches 2116 2051 -65
=============================================
- Hits 11578 7598 -3980
- Misses 9608 13241 +3633
+ Partials 925 585 -340
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [272 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.28%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.28% 0.00% -52.29%
============================================
Files 899 175 -724
Lines 22111 4163 -17948
Branches 2116 480 -1636
============================================
- Hits 11561 0 -11561
+ Misses 9627 4163 -5464
+ Partials 923 0 -923
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `20.26%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 32.09% -20.27%
+ Complexity 3362 2070 -1292
=============================================
Files 899 876 -23
Lines 22111 21468 -643
Branches 2116 2036 -80
=============================================
- Hits 11578 6890 -4688
- Misses 9608 14079 +4471
+ Partials 925 499 -426
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [291 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 177 -721
Lines 22099 4116 -17983
Branches 2116 473 -1643
============================================
- Hits 11533 0 -11533
+ Misses 9639 4116 -5523
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `35.17%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 35.17% 0.00% -35.18%
============================================
Files 880 174 -706
Lines 21560 4153 -17407
Branches 2066 480 -1586
============================================
- Hits 7584 0 -7584
+ Misses 13414 4153 -9261
+ Partials 562 0 -562
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-74.29%)` | `0.00% <0.00%> (-7.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | `0.00% <0.00%> (-8.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [703 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `9.72%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 42.63% -9.73%
+ Complexity 3362 2882 -480
============================================
Files 899 898 -1
Lines 22111 22038 -73
Branches 2116 2111 -5
============================================
- Hits 11578 9396 -2182
- Misses 9608 11844 +2236
+ Partials 925 798 -127
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [135 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **increase** coverage by `0.19%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.36% 52.55% +0.19%
+ Complexity 3362 3361 -1
============================================
Files 899 897 -2
Lines 22111 22025 -86
Branches 2116 2107 -9
============================================
- Hits 11578 11575 -3
+ Misses 9608 9525 -83
Partials 925 925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [17 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `5.96%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 46.40% -5.97%
+ Complexity 3362 3040 -322
============================================
Files 899 897 -2
Lines 22111 22000 -111
Branches 2116 2096 -20
============================================
- Hits 11578 10208 -1370
- Misses 9608 10932 +1324
+ Partials 925 860 -65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [95 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui removed a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui removed a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691422711
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `6.37%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 45.99% -6.38%
+ Complexity 3362 2356 -1006
============================================
Files 899 897 -2
Lines 22111 22000 -111
Branches 2116 2096 -20
============================================
- Hits 11578 10118 -1460
- Misses 9608 11022 +1414
+ Partials 925 860 -65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [104 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691426637
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 166 -732
Lines 22099 3978 -18121
Branches 2116 461 -1655
============================================
- Hits 11533 0 -11533
+ Misses 9639 3978 -5661
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [864 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui removed a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui removed a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691422711
<img width="1145" alt="屏幕快照 2020-09-12 下午2 13 33" src="https://user-images.githubusercontent.com/1477791/92988907-6adf9a00-f502-11ea-9ccd-2d1777c7ac2d.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui removed a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui removed a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691422711
<img width="1145" alt="屏幕快照 2020-09-12 下午2 13 33" src="https://user-images.githubusercontent.com/1477791/92988907-6adf9a00-f502-11ea-9ccd-2d1777c7ac2d.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `15.42%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 36.94% -15.43%
+ Complexity 3362 2346 -1016
=============================================
Files 899 897 -2
Lines 22111 22000 -111
Branches 2116 2096 -20
=============================================
- Hits 11578 8127 -3451
- Misses 9608 13252 +3644
+ Partials 925 621 -304
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [242 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.58% -1.78%
+ Complexity 3362 727 -2635
============================================
Files 899 178 -721
Lines 22111 4244 -17867
Branches 2116 485 -1631
============================================
- Hits 11578 2147 -9431
+ Misses 9608 1834 -7774
+ Partials 925 263 -662
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
| [...core/plugin/bytebuddy/AnnotationTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bbm5vdGF0aW9uVHlwZU5hbWVNYXRjaC5qYXZh) | | | |
| [...iver/clr/provider/handler/CLRSourceDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctY2xyLXJlY2VpdmVyLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3JlY2VpdmVyL2Nsci9wcm92aWRlci9oYW5kbGVyL0NMUlNvdXJjZURpc3BhdGNoZXIuamF2YQ==) | | | |
| [.../core/analysis/manual/log/HTTPAccessLogRecord.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2xvZy9IVFRQQWNjZXNzTG9nUmVjb3JkLmphdmE=) | | | |
| [.../library/util/prometheus/metrics/MetricFamily.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL01ldHJpY0ZhbWlseS5qYXZh) | | | |
| [...p/server/receiver/zipkin/ZipkinReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vWmlwa2luUmVjZWl2ZXJNb2R1bGUuamF2YQ==) | | | |
| [.../analysis/transform/Zipkin2SkyWalkingTransfer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vYW5hbHlzaXMvdHJhbnNmb3JtL1ppcGtpbjJTa3lXYWxraW5nVHJhbnNmZXIuamF2YQ==) | | | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `21.95%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 30.40% -21.96%
+ Complexity 3362 1940 -1422
=============================================
Files 899 862 -37
Lines 22111 21185 -926
Branches 2116 2011 -105
=============================================
- Hits 11578 6442 -5136
- Misses 9608 14259 +4651
+ Partials 925 484 -441
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [334 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 170 -728
Lines 22099 4052 -18047
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4052 -5587
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 177 -722
Lines 22111 4205 -17906
Branches 2116 484 -1632
============================================
- Hits 11578 0 -11578
+ Misses 9608 4205 -5403
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [854 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `12.32%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 40.04% -12.33%
+ Complexity 3362 2477 -885
=============================================
Files 899 877 -22
Lines 22111 21485 -626
Branches 2116 2055 -61
=============================================
- Hits 11578 8603 -2975
- Misses 9608 12236 +2628
+ Partials 925 646 -279
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [221 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.85%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.50% -1.86%
+ Complexity 3362 3256 -106
============================================
Files 899 896 -3
Lines 22111 21980 -131
Branches 2116 2101 -15
============================================
- Hits 11578 11102 -476
- Misses 9608 9976 +368
+ Partials 925 902 -23
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [57 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.26%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.10% -0.27%
+ Complexity 3362 3351 -11
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11545 -33
- Misses 9608 9686 +78
- Partials 925 928 +3
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| [...r/cluster/plugin/standalone/StandaloneManager.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1zdGFuZGFsb25lLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL3N0YW5kYWxvbmUvU3RhbmRhbG9uZU1hbmFnZXIuamF2YQ==) | `77.77% <0.00%> (-22.23%)` | `3.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/worker/TopNWorker.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvd29ya2VyL1RvcE5Xb3JrZXIuamF2YQ==) | `43.75% <0.00%> (-12.50%)` | `4.00% <0.00%> (-1.00%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 158 -741
Lines 22111 3800 -18311
Branches 2116 439 -1677
============================================
- Hits 11578 0 -11578
+ Misses 9608 3800 -5808
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [869 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691425126
doesn't matter, it is inner ip
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `11.63%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 40.73% -11.64%
+ Complexity 3362 2498 -864
=============================================
Files 899 877 -22
Lines 22111 21485 -626
Branches 2116 2055 -61
=============================================
- Hits 11578 8751 -2827
- Misses 9608 12085 +2477
+ Partials 925 649 -276
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [217 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `6.37%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 45.99% -6.38%
+ Complexity 3362 3011 -351
============================================
Files 899 897 -2
Lines 22111 22000 -111
Branches 2116 2096 -20
============================================
- Hits 11578 10118 -1460
- Misses 9608 11022 +1414
+ Partials 925 860 -65
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [104 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.92%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.44% -1.93%
+ Complexity 3362 3246 -116
============================================
Files 899 896 -3
Lines 22111 21970 -141
Branches 2116 2101 -15
============================================
- Hits 11578 11082 -496
- Misses 9608 9985 +377
+ Partials 925 903 -22
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...ver/library/server/grpc/ssl/DynamicSslContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXNlcnZlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvc2VydmVyL2dycGMvc3NsL0R5bmFtaWNTc2xDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-80.96%)` | `0.00% <0.00%> (-6.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| ... and [63 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `62.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.36% 52.57% +0.20%
+ Complexity 3362 3352 -10
============================================
Files 899 1591 +692
Lines 22111 33922 +11811
Branches 2116 3687 +1571
============================================
+ Hits 11578 17833 +6255
- Misses 9608 15236 +5628
+ Partials 925 853 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/wechat/WechatSettings.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0U2V0dGluZ3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `67.53% <10.00%> (+13.90%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `94.28% <100.00%> (+29.57%)` | `6.00 <0.00> (ø)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1082 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...313504c](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487373788
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `14.08%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 38.27% -14.09%
+ Complexity 3362 2429 -933
=============================================
Files 899 898 -1
Lines 22111 22078 -33
Branches 2116 2117 +1
=============================================
- Hits 11578 8451 -3127
- Misses 9608 12999 +3391
+ Partials 925 628 -297
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [205 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `22.52%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 29.83% -22.53%
+ Complexity 3362 1932 -1430
=============================================
Files 899 878 -21
Lines 22111 21476 -635
Branches 2116 2047 -69
=============================================
- Hits 11578 6407 -5171
- Misses 9608 14597 +4989
+ Partials 925 472 -453
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [330 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **increase** coverage by `0.20%`.
> The diff coverage is `62.26%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.36% 52.57% +0.20%
+ Complexity 3362 3352 -10
============================================
Files 899 1591 +692
Lines 22111 33922 +11811
Branches 2116 3687 +1571
============================================
+ Hits 11578 17833 +6255
- Misses 9608 15236 +5628
+ Partials 925 853 -72
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ver/core/alarm/provider/wechat/WechatSettings.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0U2V0dGluZ3MuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `67.53% <10.00%> (+13.90%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `75.00% <75.00%> (ø)` | `2.00 <2.00> (?)` | |
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `94.28% <100.00%> (+29.57%)` | `6.00 <0.00> (ø)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...erver/receiver/envoy/MetricServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvTWV0cmljU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `12.16% <0.00%> (-77.84%)` | `2.00% <0.00%> (ø%)` | |
| [...er/receiver/envoy/AccessLogServiceGRPCHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvQWNjZXNzTG9nU2VydmljZUdSUENIYW5kbGVyLmphdmE=) | `20.75% <0.00%> (-37.15%)` | `2.00% <0.00%> (ø%)` | |
| [...skywalking/oap/server/core/alarm/AlarmMessage.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYWxhcm0vQWxhcm1NZXNzYWdlLmphdmE=) | `66.66% <0.00%> (-33.34%)` | `2.00% <0.00%> (ø%)` | |
| ... and [1082 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 161 -737
Lines 22099 3842 -18257
Branches 2116 439 -1677
============================================
- Hits 11533 0 -11533
+ Misses 9639 3842 -5797
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [868 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.27%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.45% +0.27%
+ Complexity 3352 3348 -4
============================================
Files 898 892 -6
Lines 22099 22004 -95
Branches 2116 2107 -9
============================================
+ Hits 11533 11543 +10
+ Misses 9639 9536 -103
+ Partials 927 925 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `46.96% <0.00%> (-4.55%)` | `9.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [14 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 177 173 -4
Lines 4205 4081 -124
Branches 484 463 -21
=======================================
+ Misses 4205 4081 -124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691424350
Could you trigger a real alarm? I want to post this on twitter and forward it to the QQ groups.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.03%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.22% +0.03%
+ Complexity 3352 3351 -1
============================================
Files 898 899 +1
Lines 22099 22112 +13
Branches 2116 2118 +2
============================================
+ Hits 11533 11548 +15
+ Misses 9639 9637 -2
Partials 927 927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `51.66% <0.00%> (-3.34%)` | `14.00% <0.00%> (-2.00%)` | |
| ... and [10 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `3.70%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 48.65% -3.71%
+ Complexity 3362 3202 -160
============================================
Files 899 898 -1
Lines 22111 22112 +1
Branches 2116 2118 +2
============================================
- Hits 11578 10759 -819
- Misses 9608 10469 +861
+ Partials 925 884 -41
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.69%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.66% -0.70%
+ Complexity 3362 3313 -49
============================================
Files 899 896 -3
Lines 22111 22018 -93
Branches 2116 2107 -9
============================================
- Hits 11578 11376 -202
- Misses 9608 9716 +108
- Partials 925 926 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [41 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `12.35%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 40.00% -12.36%
+ Complexity 3362 2476 -886
=============================================
Files 899 877 -22
Lines 22111 21468 -643
Branches 2116 2054 -62
=============================================
- Hits 11578 8589 -2989
- Misses 9608 12233 +2625
+ Partials 925 646 -279
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [222 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487372511
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.40%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.96% -2.41%
+ Complexity 3362 3251 -111
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11071 -507
- Misses 9608 10177 +569
+ Partials 925 911 -14
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| [...nt/kafka/provider/handler/MeterServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL01ldGVyU2VydmljZUhhbmRsZXIuamF2YQ==) | `0.00% <0.00%> (-86.67%)` | `0.00% <0.00%> (-6.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.83%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.52% -0.84%
+ Complexity 3362 3333 -29
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11418 -160
- Misses 9608 9815 +207
- Partials 925 926 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [...gin/elasticsearch/query/ProfileTaskQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tRdWVyeUVzREFPLmphdmE=) | `28.57% <0.00%> (-59.19%)` | `2.00% <0.00%> (-7.00%)` | |
| [...age/plugin/elasticsearch/base/NoneStreamEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9Ob25lU3RyZWFtRXNEQU8uamF2YQ==) | `42.85% <0.00%> (-57.15%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...345c120](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 174 -725
Lines 22111 4106 -18005
Branches 2116 473 -1643
============================================
- Hits 11578 0 -11578
+ Misses 9608 4106 -5502
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.51%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.84% -2.52%
+ Complexity 3362 3263 -99
============================================
Files 899 900 +1
Lines 22111 22132 +21
Branches 2116 2117 +1
============================================
- Hits 11578 11032 -546
- Misses 9608 10196 +588
+ Partials 925 904 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [47 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `4.40%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 47.95% -4.41%
+ Complexity 3362 3155 -207
============================================
Files 899 900 +1
Lines 22111 22115 +4
Branches 2116 2103 -13
============================================
- Hits 11578 10606 -972
- Misses 9608 10631 +1023
+ Partials 925 878 -47
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [.../server/core/profile/analyze/ProfileStackNode.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvcHJvZmlsZS9hbmFseXplL1Byb2ZpbGVTdGFja05vZGUuamF2YQ==) | `0.00% <0.00%> (-87.97%)` | `0.00% <0.00%> (-26.00%)` | |
| [...fka/provider/handler/ServiceManagementHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1NlcnZpY2VNYW5hZ2VtZW50SGFuZGxlci5qYXZh) | `0.00% <0.00%> (-87.50%)` | `0.00% <0.00%> (-10.00%)` | |
| ... and [60 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691399820
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691425002
Do these IPs matter? Is this OK to post?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.06%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.25% +0.06%
+ Complexity 3352 3351 -1
============================================
Files 898 897 -1
Lines 22099 22101 +2
Branches 2116 2118 +2
============================================
+ Hits 11533 11548 +15
+ Misses 9639 9626 -13
Partials 927 927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| [...ng/apm/agent/core/logging/core/AbstractLogger.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0Fic3RyYWN0TG9nZ2VyLmphdmE=) | `51.66% <0.00%> (-3.34%)` | `14.00% <0.00%> (-2.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 177 173 -4
Lines 4205 4081 -124
Branches 484 463 -21
=======================================
+ Misses 4205 4081 -124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.17%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.35% +0.17%
+ Complexity 3352 3342 -10
============================================
Files 898 892 -6
Lines 22099 22004 -95
Branches 2116 2107 -9
============================================
- Hits 11533 11521 -12
+ Misses 9639 9558 -81
+ Partials 927 925 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `56.60% <0.00%> (-16.99%)` | `8.00% <0.00%> (-2.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `54.00% <0.00%> (-6.00%)` | `6.00% <0.00%> (-1.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487359648
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
According to this doc, it seems to belong to Enterprise WeChat, could you confirm? Where is the doc about how to get a group robot?
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/Rules.java
##########
@@ -34,6 +35,7 @@
private List<String> webhooks;
private GRPCAlarmSetting grpchookSetting;
private SlackSettings slacks;
+ private WechatSettings wechatSetting;
Review comment:
Different naming style. Please fix.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
Review comment:
Remove the link from the comments.
##########
File path: oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/wechat/WechatHookCallback.java
##########
@@ -0,0 +1,102 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ *
+ */
+
+package org.apache.skywalking.oap.server.core.alarm.provider.wechat;
+
+import io.netty.handler.codec.http.HttpHeaderValues;
+import lombok.extern.slf4j.Slf4j;
+import org.apache.http.HttpHeaders;
+import org.apache.http.HttpStatus;
+import org.apache.http.StatusLine;
+import org.apache.http.client.config.RequestConfig;
+import org.apache.http.client.methods.CloseableHttpResponse;
+import org.apache.http.client.methods.HttpPost;
+import org.apache.http.entity.ContentType;
+import org.apache.http.entity.StringEntity;
+import org.apache.http.impl.client.CloseableHttpClient;
+import org.apache.http.impl.client.HttpClients;
+import org.apache.skywalking.oap.server.core.alarm.AlarmCallback;
+import org.apache.skywalking.oap.server.core.alarm.AlarmMessage;
+import org.apache.skywalking.oap.server.core.alarm.provider.AlarmRulesWatcher;
+
+import java.io.IOException;
+import java.util.List;
+
+/**
+ * Use SkyWalking alarm wechat webhook API.
+ * See https://work.weixin.qq.com/api/doc/90000/90136/91770
+ */
+@Slf4j
+public class WechatHookCallback implements AlarmCallback {
+ private static final int HTTP_CONNECT_TIMEOUT = 1000;
+ private static final int HTTP_CONNECTION_REQUEST_TIMEOUT = 1000;
+ private static final int HTTP_SOCKET_TIMEOUT = 10000;
+ private AlarmRulesWatcher alarmRulesWatcher;
+ private RequestConfig requestConfig;
+
+ public WechatHookCallback(final AlarmRulesWatcher alarmRulesWatcher) {
+ this.alarmRulesWatcher = alarmRulesWatcher;
+ this.requestConfig = RequestConfig.custom()
+ .setConnectTimeout(HTTP_CONNECT_TIMEOUT)
+ .setConnectionRequestTimeout(HTTP_CONNECTION_REQUEST_TIMEOUT)
+ .setSocketTimeout(HTTP_SOCKET_TIMEOUT)
+ .build();
+ }
+
+ @Override
+ public void doAlarm(List<AlarmMessage> alarmMessages) {
+ if (this.alarmRulesWatcher.getWechatSettings() == null || this.alarmRulesWatcher.getWechatSettings().getWebhooks().isEmpty()) {
+ return;
+ }
+ CloseableHttpClient httpClient = HttpClients.custom().build();
+ try {
+ this.alarmRulesWatcher.getWechatSettings().getWebhooks().forEach(url -> {
+ alarmMessages.forEach(alarmMessage -> {
+ String requestBody = String.format(
+ this.alarmRulesWatcher.getWechatSettings().getTextTemplate(), alarmMessage.getAlarmMessage()
+ );
+ sendAlarmMessage(httpClient, url, requestBody);
+ });
+ });
+ } finally {
+ try {
+ httpClient.close();
+ } catch (IOException e) {
+ log.error(e.getMessage(), e);
+ }
+ }
+ }
+
+ private void sendAlarmMessage(CloseableHttpClient httpClient, String url, String requestBody) {
+ try {
+ HttpPost post = new HttpPost(url);
+ post.setConfig(requestConfig);
+ post.setHeader(HttpHeaders.ACCEPT, HttpHeaderValues.APPLICATION_JSON.toString());
+ post.setHeader(HttpHeaders.CONTENT_TYPE, HttpHeaderValues.APPLICATION_JSON.toString());
+ StringEntity entity = new StringEntity(requestBody, ContentType.APPLICATION_JSON);
+ post.setEntity(entity);
+ CloseableHttpResponse httpResponse = httpClient.execute(post);
+ StatusLine statusLine = httpResponse.getStatusLine();
+ if (statusLine != null && statusLine.getStatusCode() != HttpStatus.SC_OK) {
+ log.error("send wechat alarm to " + url + " failure. Response code: " + statusLine.getStatusCode());
Review comment:
Don't connect the literal strings with `+`. There is no performance issue in the JDK8+, but this is not good for reading. Please use `{}` for the place holder.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
No, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Then let's indicate it clearly in the document. Because people may be misguided by the current doc. The first look to me is, this works on any WeChat until I open the API doc you linked.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message will send through HTTP post by `application/json` content type if you configured Wechat Webhooks as following:
Review comment:
```suggestion
The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
```suggestion
Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
`WeCom` is from the official website.
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Take a look at my previous comment. This seems not called enterprise wechat.
##########
File path: oap-server/server-bootstrap/src/main/resources/alarm-settings.yml
##########
@@ -59,3 +59,13 @@ slackHooks:
webhooks:
# - https://hooks.slack.com/services/x/y/zssss
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Note, only WeCom(WeChat Company Edition) supports webhook. To use the WeChat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
+The alarm message would send through HTTP post by `application/json` content type after you set up Wechat Webhooks as following:
+```yml
+wechatHooks:
+ textTemplate: |-
+ {
+ "msgtype": "text",
+ "text": {
+ "content": "Apache Skywalking Alarm: \n %s."
Review comment:
```suggestion
"content": "Apache SkyWalking Alarm: \n %s."
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.26%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.10% -2.27%
+ Complexity 3362 3265 -97
============================================
Files 899 897 -2
Lines 22111 22111
Branches 2116 2118 +2
============================================
- Hits 11578 11078 -500
- Misses 9608 10109 +501
+ Partials 925 924 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| ... and [44 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `8.39%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 43.96% -8.40%
+ Complexity 3362 2959 -403
============================================
Files 899 898 -1
Lines 22111 22069 -42
Branches 2116 2116
============================================
- Hits 11578 9703 -1875
- Misses 9608 11564 +1956
+ Partials 925 802 -123
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [102 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `41.91%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 41.91% 0.00% -41.92%
============================================
Files 897 175 -722
Lines 22105 4163 -17942
Branches 2116 480 -1636
============================================
- Hits 9265 0 -9265
+ Misses 12163 4163 -8000
+ Partials 677 0 -677
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-74.29%)` | `0.00% <0.00%> (-7.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | `0.00% <0.00%> (-8.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [719 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `19.27%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 33.09% -19.28%
+ Complexity 3362 2103 -1259
=============================================
Files 899 879 -20
Lines 22111 21523 -588
Branches 2116 2063 -53
=============================================
- Hits 11578 7122 -4456
- Misses 9608 13862 +4254
+ Partials 925 539 -386
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [288 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `16.00%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 36.35% -16.01%
+ Complexity 3362 2328 -1034
=============================================
Files 899 898 -1
Lines 22111 22028 -83
Branches 2116 2111 -5
=============================================
- Hits 11578 8009 -3569
- Misses 9608 13414 +3806
+ Partials 925 605 -320
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [241 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 158 -741
Lines 22111 3800 -18311
Branches 2116 439 -1677
============================================
- Hits 11578 0 -11578
+ Misses 9608 3800 -5808
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/agent/core/jvm/memory/MemoryProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL21lbW9yeS9NZW1vcnlQcm92aWRlci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| ... and [869 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...345c120](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.22%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.41% +0.22%
+ Complexity 3352 3344 -8
============================================
Files 898 892 -6
Lines 22099 22004 -95
Branches 2116 2107 -9
============================================
Hits 11533 11533
+ Misses 9639 9545 -94
+ Partials 927 926 -1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `56.60% <0.00%> (-16.99%)` | `8.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `46.96% <0.00%> (-4.55%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [15 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.35% 0.00% -52.36%
============================================
Files 899 175 -724
Lines 22111 4163 -17948
Branches 2116 480 -1636
============================================
- Hits 11576 0 -11576
+ Misses 9610 4163 -5447
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 174 -724
Lines 22099 4106 -17993
Branches 2116 473 -1643
============================================
- Hits 11533 0 -11533
+ Misses 9639 4106 -5533
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.69%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.67% -1.70%
+ Complexity 3362 3303 -59
============================================
Files 899 900 +1
Lines 22111 22149 +38
Branches 2116 2118 +2
============================================
- Hits 11578 11223 -355
- Misses 9608 10019 +411
+ Partials 925 907 -18
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.41% <0.00%> (-79.04%)` | `1.00% <0.00%> (-10.00%)` | |
| [...e/plugin/jdbc/h2/dao/H2ProfileTaskLogQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRhc2tMb2dRdWVyeURBTy5qYXZh) | `13.63% <0.00%> (-77.28%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../plugin/elasticsearch/base/HistoryDeleteEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvYmFzZS9IaXN0b3J5RGVsZXRlRXNEQU8uamF2YQ==) | `12.00% <0.00%> (-60.00%)` | `2.00% <0.00%> (-4.00%)` | |
| ... and [25 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 174 -725
Lines 22111 4106 -18005
Branches 2116 473 -1643
============================================
- Hits 11578 0 -11578
+ Misses 9608 4106 -5502
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...7bb7448](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.58% -1.78%
+ Complexity 3362 727 -2635
============================================
Files 899 178 -721
Lines 22111 4244 -17867
Branches 2116 485 -1631
============================================
- Hits 11578 2147 -9431
+ Misses 9608 1834 -7774
+ Partials 925 263 -662
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/analysis/DownSampling.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvRG93blNhbXBsaW5nLmphdmE=) | | | |
| [...ver/core/browser/source/BrowserAppPageTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYnJvd3Nlci9zb3VyY2UvQnJvd3NlckFwcFBhZ2VUcmFmZmljLmphdmE=) | | | |
| [.../server/library/util/prometheus/metrics/Gauge.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvcHJvbWV0aGV1cy9tZXRyaWNzL0dhdWdlLmphdmE=) | | | |
| [...p/server/receiver/jaeger/JaegerReceiverModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2phZWdlci1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9qYWVnZXIvSmFlZ2VyUmVjZWl2ZXJNb2R1bGUuamF2YQ==) | | | |
| [...cluster/plugin/etcd/ClusterModuleEtcdProvider.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1ldGNkLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NsdXN0ZXIvcGx1Z2luL2V0Y2QvQ2x1c3Rlck1vZHVsZUV0Y2RQcm92aWRlci5qYXZh) | | | |
| [...storage/plugin/jdbc/h2/dao/H2TopologyQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyVG9wb2xvZ3lRdWVyeURBTy5qYXZh) | | | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `19.38%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 32.98% -19.39%
+ Complexity 3362 2329 -1033
=============================================
Files 899 897 -2
Lines 22111 21834 -277
Branches 2116 2065 -51
=============================================
- Hits 11578 7201 -4377
- Misses 9608 14029 +4421
+ Partials 925 604 -321
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `82.47% <100.00%> (-15.45%)` | `15.00 <0.00> (-2.00)` | |
| [...he/skywalking/oap/server/core/source/GCPhrase.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL0dDUGhyYXNlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/oap/server/core/analysis/record/Record.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvcmVjb3JkL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...g/oap/server/core/analysis/metrics/SumMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWV0cmljcy9TdW1NZXRyaWNzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-4.00%)` | |
| ... and [248 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `12.75%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 39.60% -12.76%
+ Complexity 3362 2481 -881
=============================================
Files 899 891 -8
Lines 22111 21927 -184
Branches 2116 2080 -36
=============================================
- Hits 11578 8685 -2893
- Misses 9608 12613 +3005
+ Partials 925 629 -296
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [206 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.60%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.76% -0.61%
+ Complexity 3362 3321 -41
============================================
Files 899 896 -3
Lines 22111 22018 -93
Branches 2116 2107 -9
============================================
- Hits 11578 11397 -181
- Misses 9608 9694 +86
- Partials 925 927 +2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [36 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `2.49%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 49.86% -2.50%
+ Complexity 3362 3263 -99
============================================
Files 899 900 +1
Lines 22111 22124 +13
Branches 2116 2102 -14
============================================
- Hits 11578 11032 -546
- Misses 9608 10188 +580
+ Partials 925 904 -21
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...csearch/query/ProfileThreadSnapshotQueryEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlFc0RBTy5qYXZh) | `4.65% <0.00%> (-89.54%)` | `1.00% <0.00%> (-10.00%)` | |
| [...lugin/elasticsearch/query/ProfileTaskLogEsDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2VsYXN0aWNzZWFyY2gvcXVlcnkvUHJvZmlsZVRhc2tMb2dFc0RBTy5qYXZh) | `13.63% <0.00%> (-86.37%)` | `1.00% <0.00%> (-3.00%)` | |
| [.../server/receiver/mesh/TelemetryDataDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWVzaC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYW9wL3NlcnZlci9yZWNlaXZlci9tZXNoL1RlbGVtZXRyeURhdGFEaXNwYXRjaGVyLmphdmE=) | `6.84% <0.00%> (-80.83%)` | `2.00% <0.00%> (-12.00%)` | |
| [...n/jdbc/h2/dao/H2ProfileThreadSnapshotQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvaDIvZGFvL0gyUHJvZmlsZVRocmVhZFNuYXBzaG90UXVlcnlEQU8uamF2YQ==) | `2.45% <0.00%> (-79.00%)` | `1.00% <0.00%> (-10.00%)` | |
| ... and [52 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `9.21%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 43.14% -9.22%
+ Complexity 3362 2915 -447
============================================
Files 899 898 -1
Lines 22111 22066 -45
Branches 2116 2116
============================================
- Hits 11578 9521 -2057
- Misses 9608 11744 +2136
+ Partials 925 801 -124
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ng/oap/server/core/analysis/config/NoneStream.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvY29uZmlnL05vbmVTdHJlYW0uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ement/ui/template/UITemplateManagementService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvbWFuYWdlbWVudC91aS90ZW1wbGF0ZS9VSVRlbXBsYXRlTWFuYWdlbWVudFNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...ient/elasticsearch/ElasticSearchUpdateRequest.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LWNsaWVudC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2xpYnJhcnkvY2xpZW50L2VsYXN0aWNzZWFyY2gvRWxhc3RpY1NlYXJjaFVwZGF0ZVJlcXVlc3QuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [.../storage/plugin/jdbc/mysql/MySQLTraceQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxUcmFjZVF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...ge/plugin/jdbc/mysql/MySQLAggregationQueryDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1qZGJjLWhpa2FyaWNwLXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL3N0b3JhZ2UvcGx1Z2luL2pkYmMvbXlzcWwvTXlTUUxBZ2dyZWdhdGlvblF1ZXJ5REFPLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [125 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 173 -725
Lines 22099 4090 -18009
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4090 -5549
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [857 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `52.36%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 0.00% -52.37%
============================================
Files 899 168 -731
Lines 22111 4005 -18106
Branches 2116 455 -1661
============================================
- Hits 11578 0 -11578
+ Misses 9608 4005 -5603
+ Partials 925 0 -925
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [863 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `16.10%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 36.26% -16.11%
+ Complexity 3362 2320 -1042
=============================================
Files 899 898 -1
Lines 22111 22028 -83
Branches 2116 2111 -5
=============================================
- Hits 11578 7988 -3590
- Misses 9608 13436 +3828
+ Partials 925 604 -321
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [245 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691398937
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 174 -724
Lines 22099 4106 -17993
Branches 2116 473 -1643
============================================
- Hits 11533 0 -11533
+ Misses 9639 4106 -5533
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [856 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `11.22%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 41.14% -11.23%
+ Complexity 3362 2596 -766
=============================================
Files 899 897 -2
Lines 22111 22111
Branches 2116 2118 +2
=============================================
- Hits 11578 9097 -2481
- Misses 9608 12330 +2722
+ Partials 925 684 -241
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [179 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487362857
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Does this mean, this can't be done in a normal WeChat group?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `23.02%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 29.33% -23.03%
+ Complexity 3362 1899 -1463
=============================================
Files 899 878 -21
Lines 22111 21484 -627
Branches 2116 2060 -56
=============================================
- Hits 11578 6302 -5276
- Misses 9608 14703 +5095
+ Partials 925 479 -446
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...kywalking/oap/server/core/storage/AbstractDAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9BYnN0cmFjdERBTy5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [332 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on a change in pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on a change in pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#discussion_r487362181
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, this is the Enterprise wechat, I will change the link later
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
Yes, there is not open api for normal WeChat group, it's not illegal
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/api/doc/90000/90136/91770).
Review comment:
got it
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+Notice: This is only apply to Enterprise Webchat. To use Wechat webhook you need to follow the [Enterprise Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
Ok, thanks
##########
File path: docs/en/setup/backend/backend-alarm.md
##########
@@ -180,6 +180,23 @@ slackHooks:
- https://hooks.slack.com/services/x/y/z
```
+## WeChat Hook
+To use Wechat webhook you need to follow the [Wechat Webhooks guide](https://work.weixin.qq.com/help?doc_id=13376).
Review comment:
changed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `13.46%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 38.90% -13.47%
+ Complexity 3362 2481 -881
=============================================
Files 899 898 -1
Lines 22111 22112 +1
Branches 2116 2118 +2
=============================================
- Hits 11578 8602 -2976
- Misses 9608 12871 +3263
+ Partials 925 639 -286
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [195 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 161 -737
Lines 22099 3842 -18257
Branches 2116 439 -1677
============================================
- Hits 11533 0 -11533
+ Misses 9639 3842 -5797
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [868 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691424734
<img width="909" alt="屏幕快照 2020-09-12 下午2 27 20" src="https://user-images.githubusercontent.com/1477791/92989100-1b9a6900-f504-11ea-91e0-d6bf7258c2b7.png">
this is from prod alarm
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `1.77%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 50.58% -1.78%
+ Complexity 3362 727 -2635
============================================
Files 899 178 -721
Lines 22111 4244 -17867
Branches 2116 485 -1631
============================================
- Hits 11578 2147 -9431
+ Misses 9608 1834 -7774
+ Partials 925 263 -662
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `58.82% <0.00%> (-17.65%)` | `4.00% <0.00%> (ø%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `51.35% <0.00%> (-10.82%)` | `8.00% <0.00%> (-1.00%)` | |
| [...rg/apache/skywalking/apm/agent/core/os/OSUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvb3MvT1NVdGlsLmphdmE=) | `62.71% <0.00%> (-5.09%)` | `10.00% <0.00%> (-2.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `57.14% <0.00%> (-3.58%)` | `7.00% <0.00%> (-1.00%)` | |
| [...tion/service/ServiceRelationServerSideMetrics.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL3JlbGF0aW9uL3NlcnZpY2UvU2VydmljZVJlbGF0aW9uU2VydmVyU2lkZU1ldHJpY3MuamF2YQ==) | | | |
| [...walking/oap/server/core/storage/StorageModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc3RvcmFnZS9TdG9yYWdlTW9kdWxlLmphdmE=) | | | |
| [...walking/oap/server/receiver/envoy/als/Fetcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL2Vudm95LW1ldHJpY3MtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvZW52b3kvYWxzL0ZldGNoZXIuamF2YQ==) | | | |
| [...ver/health/checker/module/HealthCheckerModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItaGVhbHRoLWNoZWNrZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9oZWFsdGgvY2hlY2tlci9tb2R1bGUvSGVhbHRoQ2hlY2tlck1vZHVsZS5qYXZh) | | | |
| [...le/provider/handler/ProfileTaskServiceHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctcHJvZmlsZS1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9wcm9maWxlL3Byb3ZpZGVyL2hhbmRsZXIvUHJvZmlsZVRhc2tTZXJ2aWNlSGFuZGxlci5qYXZh) | | | |
| [...walking/oap/server/core/source/MemoryPoolType.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvc291cmNlL01lbW9yeVBvb2xUeXBlLmphdmE=) | | | |
| ... and [712 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `16.50%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.18% 35.68% -16.51%
+ Complexity 3352 2310 -1042
=============================================
Files 898 892 -6
Lines 22099 21958 -141
Branches 2116 2105 -11
=============================================
- Hits 11533 7836 -3697
- Misses 9639 13555 +3916
+ Partials 927 567 -360
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [227 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.28%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 52.08% -0.29%
+ Complexity 3362 3348 -14
============================================
Files 899 900 +1
Lines 22111 22159 +48
Branches 2116 2119 +3
============================================
- Hits 11578 11541 -37
- Misses 9608 9692 +84
- Partials 925 926 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...earch7/query/ProfileThreadSnapshotQueryEs7DAO.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItc3RvcmFnZS1wbHVnaW4vc3RvcmFnZS1lbGFzdGljc2VhcmNoNy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9zdG9yYWdlL3BsdWdpbi9lbGFzdGljc2VhcmNoNy9xdWVyeS9Qcm9maWxlVGhyZWFkU25hcHNob3RRdWVyeUVzN0RBTy5qYXZh) | `50.00% <0.00%> (-50.00%)` | `1.00% <0.00%> (-2.00%)` | |
| [...ent/kafka/provider/handler/ProfileTaskHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItZmV0Y2hlci1wbHVnaW4va2Fma2EtZmV0Y2hlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9hbmFseXplci9hZ2VudC9rYWZrYS9wcm92aWRlci9oYW5kbGVyL1Byb2ZpbGVUYXNrSGFuZGxlci5qYXZh) | `26.08% <0.00%> (-47.83%)` | `4.00% <0.00%> (-1.00%)` | |
| [...skywalking/oap/server/core/analysis/topn/TopN.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvdG9wbi9Ub3BOLmphdmE=) | `0.00% <0.00%> (-33.34%)` | `0.00% <0.00%> (-1.00%)` | |
| [...er/core/analysis/data/LimitedSizeBufferedData.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvZGF0YS9MaW1pdGVkU2l6ZUJ1ZmZlcmVkRGF0YS5qYXZh) | `15.38% <0.00%> (-23.08%)` | `1.00% <0.00%> (-1.00%)` | |
| ... and [12 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `16.09%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=============================================
- Coverage 52.36% 36.27% -16.10%
+ Complexity 3362 2320 -1042
=============================================
Files 899 896 -3
Lines 22111 22022 -89
Branches 2116 2111 -5
=============================================
- Hits 11578 7988 -3590
- Misses 9608 13430 +3822
+ Partials 925 604 -321
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| ... and [247 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...40ed277](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `42.63%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 42.63% 0.00% -42.64%
============================================
Files 897 175 -722
Lines 22105 4163 -17942
Branches 2116 480 -1636
============================================
- Hits 9425 0 -9425
+ Misses 11995 4163 -7832
+ Partials 685 0 -685
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...apm/commons/datacarrier/buffer/BufferStrategy.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9CdWZmZXJTdHJhdGVneS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...king/apm/util/RunnableWithExceptionProtection.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUnVubmFibGVXaXRoRXhjZXB0aW9uUHJvdGVjdGlvbi5qYXZh) | `0.00% <0.00%> (-77.78%)` | `0.00% <0.00%> (-2.00%)` | |
| [...atacarrier/partition/SimpleRollingPartitioner.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL3BhcnRpdGlvbi9TaW1wbGVSb2xsaW5nUGFydGl0aW9uZXIuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...m/commons/datacarrier/consumer/ConsumerThread.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVyVGhyZWFkLmphdmE=) | `0.00% <0.00%> (-74.29%)` | `0.00% <0.00%> (-7.00%)` | |
| [...skywalking/apm/util/PropertyPlaceholderHelper.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3V0aWwvUHJvcGVydHlQbGFjZWhvbGRlckhlbHBlci5qYXZh) | `0.00% <0.00%> (-67.61%)` | `0.00% <0.00%> (-11.00%)` | |
| [...s/datacarrier/buffer/ArrayBlockingQueueBuffer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9BcnJheUJsb2NraW5nUXVldWVCdWZmZXIuamF2YQ==) | `0.00% <0.00%> (-58.83%)` | `0.00% <0.00%> (-3.00%)` | |
| [...pm/commons/datacarrier/consumer/ConsumeDriver.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2NvbnN1bWVyL0NvbnN1bWVEcml2ZXIuamF2YQ==) | `0.00% <0.00%> (-55.56%)` | `0.00% <0.00%> (-8.00%)` | |
| [...kywalking/apm/commons/datacarrier/DataCarrier.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0RhdGFDYXJyaWVyLmphdmE=) | `0.00% <0.00%> (-51.36%)` | `0.00% <0.00%> (-7.00%)` | |
| [...lking/apm/commons/datacarrier/buffer/Channels.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL2J1ZmZlci9DaGFubmVscy5qYXZh) | `0.00% <0.00%> (-50.00%)` | `0.00% <0.00%> (-6.00%)` | |
| [...he/skywalking/apm/commons/datacarrier/EnvUtil.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLWNvbW1vbnMvYXBtLWRhdGFjYXJyaWVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9jb21tb25zL2RhdGFjYXJyaWVyL0VudlV0aWwuamF2YQ==) | `0.00% <0.00%> (-20.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [719 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **increase** coverage by `0.25%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
+ Coverage 52.18% 52.44% +0.25%
+ Complexity 3352 3348 -4
============================================
Files 898 894 -4
Lines 22099 22010 -89
Branches 2116 2107 -9
============================================
+ Hits 11533 11543 +10
+ Misses 9639 9542 -97
+ Partials 927 925 -2
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...re/logging/core/converters/ThrowableConverter.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL2NvbnZlcnRlcnMvVGhyb3dhYmxlQ29udmVydGVyLmphdmE=) | `16.66% <0.00%> (-58.34%)` | `2.00% <0.00%> (-2.00%)` | |
| [...kywalking/apm/agent/core/jvm/JVMMetricsSender.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL0pWTU1ldHJpY3NTZW5kZXIuamF2YQ==) | `82.35% <0.00%> (-5.89%)` | `11.00% <0.00%> (ø%)` | |
| [.../agent/core/profile/ProfileTaskChannelService.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlVGFza0NoYW5uZWxTZXJ2aWNlLmphdmE=) | `46.96% <0.00%> (-4.55%)` | `9.00% <0.00%> (-1.00%)` | |
| [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (-4.00%)` | `7.00% <0.00%> (ø%)` | |
| [...apm/agent/core/remote/ServiceManagementClient.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL1NlcnZpY2VNYW5hZ2VtZW50Q2xpZW50LmphdmE=) | `69.81% <0.00%> (-3.78%)` | `9.00% <0.00%> (-1.00%)` | |
| ... and [16 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...66272a4](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] xbkaishui commented on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
xbkaishui commented on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691421836
<img width="958" alt="屏幕快照 2020-09-12 下午2 08 55" src="https://user-images.githubusercontent.com/1477791/92988830-a3cb3f00-f501-11ea-8042-cca3f56f26d2.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **decrease** coverage by `0.89%`.
> The diff coverage is `22.00%`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.36% 51.47% -0.90%
+ Complexity 3362 3311 -51
============================================
Files 899 897 -2
Lines 22111 22111
Branches 2116 2118 +2
============================================
- Hits 11578 11381 -197
- Misses 9608 9804 +196
- Partials 925 926 +1
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../server/core/alarm/provider/AlarmRulesWatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9BbGFybVJ1bGVzV2F0Y2hlci5qYXZh) | `62.85% <0.00%> (-1.85%)` | `6.00 <0.00> (ø)` | |
| [...ywalking/oap/server/core/alarm/provider/Rules.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlcy5qYXZh) | `100.00% <ø> (ø)` | `1.00 <0.00> (ø)` | |
| [...ng/oap/server/core/alarm/provider/RulesReader.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9SdWxlc1JlYWRlci5qYXZh) | `49.35% <10.00%> (-4.28%)` | `3.00 <0.00> (ø)` | |
| [...core/alarm/provider/wechat/WechatHookCallback.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci93ZWNoYXQvV2VjaGF0SG9va0NhbGxiYWNrLmphdmE=) | `23.68% <23.68%> (ø)` | `2.00 <2.00> (?)` | |
| [.../oap/server/core/alarm/provider/NotifyHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItYWxhcm0tcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvY29yZS9hbGFybS9wcm92aWRlci9Ob3RpZnlIYW5kbGVyLmphdmE=) | `97.93% <100.00%> (+0.02%)` | `17.00 <0.00> (ø)` | |
| [...ing/oap/server/library/util/ProtoBufJsonUtils.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItbGlicmFyeS9saWJyYXJ5LXV0aWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9saWJyYXJ5L3V0aWwvUHJvdG9CdWZKc29uVXRpbHMuamF2YQ==) | `0.00% <0.00%> (-90.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...s/manual/database/DatabaseStatementDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2RhdGFiYXNlL0RhdGFiYXNlU3RhdGVtZW50RGlzcGF0Y2hlci5qYXZh) | `10.00% <0.00%> (-90.00%)` | `1.00% <0.00%> (-1.00%)` | |
| [...tworkalias/NetworkAddressAliasSetupDispatcher.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL25ldHdvcmthbGlhcy9OZXR3b3JrQWRkcmVzc0FsaWFzU2V0dXBEaXNwYXRjaGVyLmphdmE=) | `11.11% <0.00%> (-88.89%)` | `1.00% <0.00%> (-1.00%)` | |
| [.../v8/rest/TraceSegmentReportListServletHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctdHJhY2UtcmVjZWl2ZXItcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL29hcC9zZXJ2ZXIvcmVjZWl2ZXIvdHJhY2UvcHJvdmlkZXIvaGFuZGxlci92OC9yZXN0L1RyYWNlU2VnbWVudFJlcG9ydExpc3RTZXJ2bGV0SGFuZGxlci5qYXZh) | `22.22% <0.00%> (-66.67%)` | `2.00% <0.00%> (-3.00%)` | |
| [...ler/v8/rest/ManagementServiceKeepAliveHandler.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3NreXdhbGtpbmctbWFuYWdlbWVudC1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci9yZWdpc3Rlci9wcm92aWRlci9oYW5kbGVyL3Y4L3Jlc3QvTWFuYWdlbWVudFNlcnZpY2VLZWVwQWxpdmVIYW5kbGVyLmphdmE=) | `32.00% <0.00%> (-64.00%)` | `2.00% <0.00%> (-1.00%)` | |
| ... and [34 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...34ae89b](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/29de696c42901206848575e20dc1de2ca4943e64?el=desc) will **decrease** coverage by `52.18%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
============================================
- Coverage 52.18% 0.00% -52.19%
============================================
Files 898 172 -726
Lines 22099 4064 -18035
Branches 2116 469 -1647
============================================
- Hits 11533 0 -11533
+ Misses 9639 4064 -5575
+ Partials 927 0 -927
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ywalking/apm/agent/core/logging/core/LogLevel.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ0xldmVsLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...ywalking/apm/agent/core/plugin/EnhanceContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL0VuaGFuY2VDb250ZXh0LmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-5.00%)` | |
| [...ywalking/apm/agent/core/profile/ProfileStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcHJvZmlsZS9Qcm9maWxlU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/context/SW8CarrierItem.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9TVzhDYXJyaWVySXRlbS5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/jvm/cpu/SunCpuAccessor.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2NwdS9TdW5DcHVBY2Nlc3Nvci5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-2.00%)` | |
| [...walking/apm/agent/core/logging/core/LogOutput.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvbG9nZ2luZy9jb3JlL0xvZ091dHB1dC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...walking/apm/agent/core/plugin/match/NameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL05hbWVNYXRjaC5qYXZh) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...alking/apm/agent/core/context/CarrierItemHead.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9DYXJyaWVySXRlbUhlYWQuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| [...alking/apm/agent/core/jvm/gc/ParallelGCModule.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvanZtL2djL1BhcmFsbGVsR0NNb2R1bGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-3.00%)` | |
| [...lking/apm/agent/core/remote/GRPCChannelStatus.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcmVtb3RlL0dSUENDaGFubmVsU3RhdHVzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | `0.00% <0.00%> (-1.00%)` | |
| ... and [858 more](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [29de696...9f9b947](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5474: Alarm support wechat webhook
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #5474:
URL: https://github.com/apache/skywalking/pull/5474#issuecomment-691206637
# [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=h1) Report
> Merging [#5474](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/efd080840e9cf8e2bdd87c010701564b2ccd6d0e?el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #5474 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 177 168 -9
Lines 4205 4005 -200
Branches 484 455 -29
=======================================
+ Misses 4205 4005 -200
```
| [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ng/apm/agent/core/context/trace/LogDataEntity.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC90cmFjZS9Mb2dEYXRhRW50aXR5LmphdmE=) | | |
| [.../agent/core/context/util/ThrowableTransformer.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL1Rocm93YWJsZVRyYW5zZm9ybWVyLmphdmE=) | | |
| [...ore/plugin/bootstrap/BootstrapPluginLogBridge.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2Jvb3RzdHJhcC9Cb290c3RyYXBQbHVnaW5Mb2dCcmlkZ2UuamF2YQ==) | | |
| [...lking/apm/agent/core/plugin/match/PrefixMatch.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL21hdGNoL1ByZWZpeE1hdGNoLmphdmE=) | | |
| [...king/apm/agent/core/context/util/KeyValuePair.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC91dGlsL0tleVZhbHVlUGFpci5qYXZh) | | |
| [...alking/apm/agent/core/context/ContextSnapshot.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9Db250ZXh0U25hcHNob3QuamF2YQ==) | | |
| [.../org/apache/skywalking/apm/toolkit/model/User.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-dGVzdC9wbHVnaW4vc2NlbmFyaW9zL2FwbS10b29sa2l0LXRyYWNlLXNjZW5hcmlvL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS90b29sa2l0L21vZGVsL1VzZXIuamF2YQ==) | | |
| [...ent/core/context/status/ExceptionCheckContext.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvY29udGV4dC9zdGF0dXMvRXhjZXB0aW9uQ2hlY2tDb250ZXh0LmphdmE=) | | |
| [...lking/apm/agent/core/util/CustomizeExpression.java](https://codecov.io/gh/apache/skywalking/pull/5474/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvdXRpbC9DdXN0b21pemVFeHByZXNzaW9uLmphdmE=) | | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=footer). Last update [efd0808...f09f8ba](https://codecov.io/gh/apache/skywalking/pull/5474?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org