[PR] Fix Illegal Reflective Access Warning in Shell [accumulo]

["ddanielr (via GitHub)" <gi...@apache.org>]

ddanielr opened a new pull request, #4427:
URL: https://github.com/apache/accumulo/pull/4427

   Jline `3.24.1` throws an illegal reflective access warning when starting an accumulo shell.
   
   ```
   $ ./accumulo shell
   WARNING: An illegal reflective access operation has occurred
   WARNING: Illegal reflective access by org.jline.terminal.impl.exec.ExecTerminalProvider$ReflectionRedirectPipeCreator (file:/data/workspace/fluo-uno/install/accumulo-2.1.3-SNAPSHOT/lib/jline-3.24.1.jar) to constructor java.lang.ProcessBuilder$RedirectPipeImpl()
   WARNING: Please consider reporting this to the maintainers of org.jline.terminal.impl.exec.ExecTerminalProvider$ReflectionRedirectPipeCreator
   WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
   WARNING: All illegal access operations will be denied in a future release
   
   Shell - Apache Accumulo Interactive Shell
   - 
   - version: 2.1.3-SNAPSHOT
   - instance name: uno
   - instance id: ad82aa87-f2a2-4bfd-afa4-fc87f0384715
   - 
   - type 'help' for a list of available commands
   - 
   root@uno> exit
   ```
   This only shows up when using java 11 and does not appear when using java 17.
   
   This change updates jline to version `3.25.1` which fixes the reflective access issue.
   
   Test was updated because the TerminalBuilder now returns a `PosixPtyTerminal` vs hitting an `UnsupportedOperationException` and returning an `ExternalTerminal`.
   
   Modified the test to return the same `ExternalTerminal` that was created with Jline 3.24.1.
   
   `PosixPtyTerminal` does not set the writer to the `out` stream which was failing the test 
   https://github.com/jline/jline3/blob/c75301facc8716b59c1d57d3e3c5943358022560/terminal/src/main/java/org/jline/terminal/impl/PosixPtyTerminal.java#L77


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix Illegal Reflective Access Warning in Shell [accumulo]

["ddanielr (via GitHub)" <gi...@apache.org>]

ddanielr merged PR #4427:
URL: https://github.com/apache/accumulo/pull/4427


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org