You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/24 06:41:12 UTC

[GitHub] [pulsar] michaeljmarshall commented on a change in pull request #14317: [pulsar-client] Fix send to deadLetterTopic not working when reach maxRedeliverCount

michaeljmarshall commented on a change in pull request #14317:
URL: https://github.com/apache/pulsar/pull/14317#discussion_r813587681



##########
File path: pulsar-client/src/test/java/org/apache/pulsar/client/impl/MessageTest.java
##########
@@ -81,4 +81,15 @@ public void testTopicMessageImplNoReplicatedInfo() {
         assertFalse(topicMessage.isReplicated());
         assertNull(topicMessage.getReplicatedFrom());
     }
+
+    @Test
+    public void testMessageImplGetReaderSchema() {
+        MessageMetadata builder = new MessageMetadata();
+        builder.hasSchemaVersion();

Review comment:
       @Shawyeok - Why was this line necessary? It seems like it's not doing anything.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org