You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@santuario.apache.org by "Colm O hEigeartaigh (Jira)" <ji...@apache.org> on 2024/11/25 05:42:00 UTC

[jira] [Resolved] (SANTUARIO-622) Inputstream is not always closed by XMLSignatureInput

     [ https://issues.apache.org/jira/browse/SANTUARIO-622?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Colm O hEigeartaigh resolved SANTUARIO-622.
-------------------------------------------
    Resolution: Fixed

> Inputstream is not always closed by XMLSignatureInput
> -----------------------------------------------------
>
>                 Key: SANTUARIO-622
>                 URL: https://issues.apache.org/jira/browse/SANTUARIO-622
>             Project: Santuario
>          Issue Type: Improvement
>          Components: Java
>            Reporter: Pierrick Vandenbroucke
>            Assignee: Colm O hEigeartaigh
>            Priority: Major
>             Fix For: Java 3.0.6
>
>
> Hello,
> In the method {{updateOutputStream}} of the class {{XMLSignatureInput}}, the proxified InputStream is only closed in case of Exception (this [code|https://github.com/apache/santuario-xml-security-java/blob/3.0.x-fixes/src/main/java/org/apache/xml/security/signature/XMLSignatureInput.java#L507]).
> IMO, the close call should be in a finally clause or did I miss the reason of only closing in the catch clause ?
> I'm able to reproduce the issue of the ticket SANTUARIO-344. I'm trying to sign a file, then deleting the original file. 
> Regards,
> P.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)