You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "xhumanoid (via GitHub)" <gi...@apache.org> on 2026/09/14 15:53:39 UTC
[PR] feat: add BinaryType support for SortMergeJoin [datafusion-comet]
xhumanoid opened a new pull request, #5928:
URL: https://github.com/apache/datafusion-comet/pull/5928
BinaryType already supported on datafusion side, but still not enabled in comet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: add BinaryType support for SortMergeJoin [datafusion-comet]
Posted by "xhumanoid (via GitHub)" <gi...@apache.org>.
xhumanoid commented on PR #5928:
URL: https://github.com/apache/datafusion-comet/pull/5928#issuecomment-5667955205
@peterxcli is it ok?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: add BinaryType support for SortMergeJoin [datafusion-comet]
Posted by "peterxcli (via GitHub)" <gi...@apache.org>.
peterxcli commented on code in PR #5928:
URL: https://github.com/apache/datafusion-comet/pull/5928#discussion_r4007867372
##########
spark/src/main/scala/org/apache/spark/sql/comet/operators.scala:
##########
@@ -2797,8 +2797,11 @@ object CometSortMergeJoinExec extends CometOperatorSerde[SortMergeJoinExec] {
*/
private def supportedSortMergeJoinEqualType(dataType: DataType): Boolean = dataType match {
case st: StringType if isStringCollationType(st) => false
+ // Spark orders binary by unsigned byte, which is also how Arrow orders `Binary`, so the
+ // sorted inputs Spark guarantees agree with DataFusion's SMJ key comparator.
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: add BinaryType support for SortMergeJoin [datafusion-comet]
Posted by "xhumanoid (via GitHub)" <gi...@apache.org>.
xhumanoid commented on PR #5928:
URL: https://github.com/apache/datafusion-comet/pull/5928#issuecomment-5669299432
@andygrove could you check, please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] feat: add BinaryType support for SortMergeJoin [datafusion-comet]
Posted by "sunchao (via GitHub)" <gi...@apache.org>.
sunchao merged PR #5928:
URL: https://github.com/apache/datafusion-comet/pull/5928
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org