[GitHub] [spark] HyukjinKwon commented on a change in pull request #34614: [SPARK-37277][PYTHON][SQL] Support DayTimeIntervalType in createDataFrame and Python UDF

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34614:
URL: https://github.com/apache/spark/pull/34614#discussion_r749878262



##########
File path: python/pyspark/sql/types.py
##########
@@ -1034,11 +1089,19 @@ def _parse_datatype_json_value(json_value: Union[dict, str]) -> DataType:
             return _all_atomic_types[json_value]()
         elif json_value == "decimal":
             return DecimalType()
-        elif json_value == "timestamp_ntz":
-            return TimestampNTZType()

Review comment:
       This is unreachable. `if json_value in _all_atomic_types.keys():` above handles it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org