You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Manny Lim (JIRA)" <ji...@apache.org> on 2009/07/24 19:58:14 UTC

[jira] Created: (AXIS2-4449) DependencyMananger.initService(ServiceGroupContext) does not throw AxisFault on service object initialization failure.

DependencyMananger.initService(ServiceGroupContext) does not throw AxisFault on service object initialization failure.
----------------------------------------------------------------------------------------------------------------------

                 Key: AXIS2-4449
                 URL: https://issues.apache.org/jira/browse/AXIS2-4449
             Project: Axis 2.0 (Axis2)
          Issue Type: Bug
          Components: kernel
    Affects Versions: 1.5
         Environment: All
            Reporter: Manny Lim
            Priority: Minor


DependencyManager.initService(ServiceGroupContext) method does not actually "throw" any Exceptions caught as a result of service object initialization failure (initServiceObject((serviceImpl, serviceContext)). The Exception is caught and then an AxisFault is created from it, but the AxisFault is not thrown.

As a result, I was unable to catch application scoped service initialization failures. Below is a patch to quickly fix this bug:

Index: DependencyManager.java
===================================================================
--- DependencyManager.java	(revision 797569)
+++ DependencyManager.java	(working copy)
@@ -129,7 +129,7 @@
                     serviceContext.setProperty(ServiceContext.SERVICE_OBJECT, serviceImpl);
                     initServiceObject(serviceImpl, serviceContext);
                 } catch (Exception e) {
-                    AxisFault.makeFault(e);
+                    throw AxisFault.makeFault(e);
                 }
             }
         }


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (AXIS2-4449) DependencyMananger.initService(ServiceGroupContext) does not throw AxisFault on service object initialization failure.

Posted by "Andreas Veithen (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-4449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andreas Veithen resolved AXIS2-4449.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.6
         Assignee: Andreas Veithen

Applied the patch. Thanks!

> DependencyMananger.initService(ServiceGroupContext) does not throw AxisFault on service object initialization failure.
> ----------------------------------------------------------------------------------------------------------------------
>
>                 Key: AXIS2-4449
>                 URL: https://issues.apache.org/jira/browse/AXIS2-4449
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>          Components: kernel
>    Affects Versions: 1.5
>         Environment: All
>            Reporter: Manny Lim
>            Assignee: Andreas Veithen
>            Priority: Minor
>             Fix For: 1.6
>
>
> DependencyManager.initService(ServiceGroupContext) method does not actually "throw" any Exceptions caught as a result of service object initialization failure (initServiceObject((serviceImpl, serviceContext)). The Exception is caught and then an AxisFault is created from it, but the AxisFault is not thrown.
> As a result, I was unable to catch application scoped service initialization failures. Below is a patch to quickly fix this bug:
> Index: DependencyManager.java
> ===================================================================
> --- DependencyManager.java	(revision 797569)
> +++ DependencyManager.java	(working copy)
> @@ -129,7 +129,7 @@
>                      serviceContext.setProperty(ServiceContext.SERVICE_OBJECT, serviceImpl);
>                      initServiceObject(serviceImpl, serviceContext);
>                  } catch (Exception e) {
> -                    AxisFault.makeFault(e);
> +                    throw AxisFault.makeFault(e);
>                  }
>              }
>          }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.