[GitHub] [superset] villebro commented on a change in pull request #16862: feat: add Databricks ODBC engine spec

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #16862:
URL: https://github.com/apache/superset/pull/16862#discussion_r717210256



##########
File path: superset/db_engine_specs/databricks.py
##########
@@ -15,11 +15,34 @@
 # specific language governing permissions and limitations
 # under the License.o
 
+from datetime import datetime
+from typing import Optional
+
+from superset.db_engine_specs.base import BaseEngineSpec
 from superset.db_engine_specs.hive import HiveEngineSpec
 
 
 class DatabricksHiveEngineSpec(HiveEngineSpec):
     engine = "databricks"
-    engine_name = "Databricks"
+    engine_name = "Databricks (Hive)"

Review comment:
       nit: to avoid confusion, maybe this should be "Databricks (PyHive)"




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org