You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by Leemoonsoo <gi...@git.apache.org> on 2018/11/17 15:26:40 UTC

[GitHub] zeppelin pull request #3230: [ZEPPELIN-3847] Duplicate results in notebooks ...

GitHub user Leemoonsoo opened a pull request:

    https://github.com/apache/zeppelin/pull/3230

    [ZEPPELIN-3847] Duplicate results in notebooks due to WS interruption

    ### What is this PR for?
    Duplicate results in notebooks after ws reconnect.
    The problem occurs via duplicated 'setConnectedStatus' event handler in notebook.controller.js.
    The same function exists at https://github.com/Leemoonsoo/zeppelin/blob/dbbf0436490941d117fd4c06b9da5b6cb47697ff/zeppelin-web/src/app/notebook/notebook.controller.js#L99-L104.
    
    
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3847
    
    ### How should this be tested?
    Disconnect and reconnect websocket connection to browser, and check if result is duplicated.
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-3847

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3230.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3230
    
----
commit dbbf0436490941d117fd4c06b9da5b6cb47697ff
Author: Lee moon soo <le...@...>
Date:   2018-11-17T01:06:30Z

    remove duplicated setConnectedStatus event handler

----


---

[GitHub] zeppelin issue #3230: [ZEPPELIN-3847] Duplicate results in notebooks due to ...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/3230
  
    Thanks @zjffdu, @felixcheung for review. Merge to master and branch-0.8.


---

[GitHub] zeppelin issue #3230: [ZEPPELIN-3847] Duplicate results in notebooks due to ...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/3230
  
    LGTM


---

[GitHub] zeppelin pull request #3230: [ZEPPELIN-3847] Duplicate results in notebooks ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/3230


---