You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/10 12:08:16 UTC

[GitHub] [superset] villebro commented on pull request #17898: feat: Add support for Azure Data Explorer (Kusto) db engine spec

villebro commented on pull request #17898:
URL: https://github.com/apache/superset/pull/17898#issuecomment-1008812478


   @xneg awesome 👍 I started CI and this definitely LGTM if it passes CI. Again, to further protect this connector from the unlikely risk of regressions I'd suggest adding unit tests for all overridden methods (e.g. convert_dttm etc), but I'm fine merging as-is.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org