You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Stefan Miklosovic (Jira)" <ji...@apache.org> on 2022/11/11 11:47:00 UTC

[jira] [Comment Edited] (CASSANDRA-17287) Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'

    [ https://issues.apache.org/jira/browse/CASSANDRA-17287?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17632272#comment-17632272 ] 

Stefan Miklosovic edited comment on CASSANDRA-17287 at 11/11/22 11:46 AM:
--------------------------------------------------------------------------

I am getting this:

https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2017/jdk=jdk_1.8_latest,label=cassandra/console

{code}
12:13:32 BUILD FAILED
12:13:32 /home/jenkins/jenkins-slave/workspace/Cassandra-devbranch-artifacts/jdk/jdk_1.8_latest/label/cassandra/.build/build-resolver.xml:233: Warning: Could not find resource file "/home/jenkins/.m2/repository/org/apache/cassandra/deps/wcwidth-0.2.5-py2-py3-none-any.zip" to copy.
{code}

Same locally doing ant realclean && ant artifacts:

{code}
/home/smiklosovic/dev/cassandra/cassandra-instaclustr/cassandra/.build/build-resolver.xml:233: Warning: Could not find resource file "/home/smiklosovic/.m2/repository/org/apache/cassandra/deps/wcwidth-0.2.5-py2-py3-none-any.zip" to copy.
{code}




was (Author: smiklosovic):
I am getting this:

https://ci-cassandra.apache.org/job/Cassandra-devbranch-artifacts/2017/jdk=jdk_1.8_latest,label=cassandra/console

{code}
12:13:32 BUILD FAILED
12:13:32 /home/jenkins/jenkins-slave/workspace/Cassandra-devbranch-artifacts/jdk/jdk_1.8_latest/label/cassandra/.build/build-resolver.xml:233: Warning: Could not find resource file "/home/jenkins/.m2/repository/org/apache/cassandra/deps/wcwidth-0.2.5-py2-py3-none-any.zip" to copy.
{code}

Same locally:

{code}
/home/smiklosovic/dev/cassandra/cassandra-instaclustr/cassandra/.build/build-resolver.xml:233: Warning: Could not find resource file "/home/smiklosovic/.m2/repository/org/apache/cassandra/deps/wcwidth-0.2.5-py2-py3-none-any.zip" to copy.
{code}



> Replace cqlshlib/wcwidth.py with pypi module 'wcwidth'
> ------------------------------------------------------
>
>                 Key: CASSANDRA-17287
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17287
>             Project: Cassandra
>          Issue Type: Task
>          Components: CQL/Interpreter
>            Reporter: Brad Schoening
>            Assignee: Brad Schoening
>            Priority: Normal
>             Fix For: 4.x
>
>         Attachments: CQLSH sample query.jpg
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> The module wcwidth implements the same Markus Kuhn algorithm defined in POSIX.1-2008 to return the number of cells a unicode string is expected to occupy.
> The module wcwidth is used by hundreds of libraries including pytest and prompt-toolkit (used in ipython).  It replaces 379 lines of bespoke code in cqlshlib.
> {quote}from wcwidth import wcswidth   # at [https://pypi.org/project/wcwidth/]
> print(wcswidth('コンニチハ'))
> 10
> {{from cqlshlib.wcwidth import wcswidth as cql_wcswidth}}
> print(cql_wcswidth('コンニチハ'))
> 10
> {quote}
> wcwidth appears to be used only by one line in formatting.py:
>  return bval if colormap is NO_COLOR_MAP else color_text(bval, colormap, wcwidth.wcswidth(bval))



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org