You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by HansBrende <gi...@git.apache.org> on 2018/06/29 22:28:12 UTC
[GitHub] any23 pull request #91: ANY23-356 clean up poms from cli/core/encoding/mime/...
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/91
ANY23-356 clean up poms from cli/core/encoding/mime/service/parent, update deps.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-356
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/91.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #91
----
commit 02b8895830007e335e5118741815a1593b045ca0
Author: Hans <fi...@...>
Date: 2018-06-29T22:26:25Z
ANY23-356 clean up poms from cli/core/encoding/mime/service/parent, update deps.
----
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on the issue:
https://github.com/apache/any23/pull/91
@lewismc can you take another look at the `build.txt` file you attached? It doesn't contain any errors.
---
[GitHub] any23 issue #91: ANY23-356 clean up poms from cli/core/encoding/mime/service...
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on the issue:
https://github.com/apache/any23/pull/91
@lewismc Update: this PR knocks out all of 1, 2, and 3 in ANY23-354. Any comments before I merge?
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/91
+1 please merge excellent job
On Thu, Jul 5, 2018 at 14:16 Hans Brende <no...@github.com> wrote:
> @lewismc <https://github.com/lewismc> I just ran mvn clean install myself
> after my latest commit, and the project built successfully. Can you confirm?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/any23/pull/91#issuecomment-402855293>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABHJl9A3HDYVRl5sN91OaREAeKbkSHpQks5uDoI0gaJpZM4U9s3L>
> .
>
--
*Lewis*
Dr. Lewis J. McGibbney Ph.D, B.Sc
*Skype*: lewis.john.mcgibbney
---
[GitHub] any23 issue #91: ANY23-356 clean up poms from cli/core/encoding/mime/service...
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on the issue:
https://github.com/apache/any23/pull/91
@lewismc This PR knocks out all of 2 and 3 in ANY23-354. Any comments?
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on the issue:
https://github.com/apache/any23/pull/91
@lewismc I searched through your `build.txt` file, but there aren't any `NoClassDefFoundError`s that I can find, so I'm not exactly sure what you're referring to. Also it looks like all tests completed successfully! Here's the last snippet of `build.txt`:
```
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Any23 2.3-SNAPSHOT .......................... SUCCESS [ 10.907 s]
[INFO] Apache Any23 :: Base API ........................... SUCCESS [ 5.086 s]
[INFO] Apache Any23 :: Test Resources ..................... SUCCESS [ 0.875 s]
[INFO] Apache Any23 :: CSV Utilities ...................... SUCCESS [ 0.375 s]
[INFO] Apache Any23 :: Mime Type Detection ................ SUCCESS [ 7.968 s]
[INFO] Apache Any23 :: Encoding Detection ................. SUCCESS [ 1.494 s]
[INFO] Apache Any23 :: Core ............................... SUCCESS [ 44.988 s]
[INFO] Apache Any23 :: Plugins :: Office Scraper .......... SUCCESS [ 4.799 s]
[INFO] Apache Any23 :: Plugins :: HTML Scraper ............ SUCCESS [ 1.845 s]
[INFO] Apache Any23 :: CLI ................................ SUCCESS [ 15.713 s]
[INFO] Apache Any23 :: Plugins :: Basic Crawler ........... SUCCESS [ 41.085 s]
[INFO] Apache Any23 :: Plugins :: OpenIE .................. SUCCESS [ 0.520 s]
[INFO] Apache Any23 :: Plugins :: Integration Test ........ SUCCESS [01:08 min]
[INFO] Apache Any23 :: Service 2.3-SNAPSHOT ............... SUCCESS [04:34 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 07:58 min
[INFO] Finished at: 2018-07-02T14:14:11-07:00
[INFO] ------------------------------------------------------------------------
```
Did you attach the wrong file perhaps?
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on the issue:
https://github.com/apache/any23/pull/91
@lewismc I just ran `mvn clean install` myself after my latest commit, and the project built successfully. Can you confirm?
---
[GitHub] any23 pull request #91: ANY23-356 update all dependencies
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/any23/pull/91
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by HansBrende <gi...@git.apache.org>.
Github user HansBrende commented on the issue:
https://github.com/apache/any23/pull/91
@lewismc Ah, the error appeared to be caused because of conflicting versions of the logback slf4j binding. I excluded it from our dependencies since we use the log4j binding anyway. Try now!
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/91
Hi @HansBrende please see the attachment, there are some NoDefClassFound issues which I think are probably leading to broken test suite.
[build.txt](https://github.com/apache/any23/files/2156812/build.txt)
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/91
Wow @HansBrende this looks great. I'll scope it out right now.
---
[GitHub] any23 issue #91: ANY23-356 update all dependencies
Posted by lewismc <gi...@git.apache.org>.
Github user lewismc commented on the issue:
https://github.com/apache/any23/pull/91
@HansBrende see attached file. The exception is present towards the end of the file. Thsi output is generated directly on the terminal. Can you reproduce this
```mvn clean install > build.txt```
[build_out.txt](https://github.com/apache/any23/files/2167923/build_out.txt)
---