You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jonathan Gray (JIRA)" <ji...@apache.org> on 2011/03/15 00:23:29 UTC
[jira] Created: (HBASE-3641) LruBlockCache.CacheStats.getHitCount()
is not using the correct variable
LruBlockCache.CacheStats.getHitCount() is not using the correct variable
------------------------------------------------------------------------
Key: HBASE-3641
URL: https://issues.apache.org/jira/browse/HBASE-3641
Project: HBase
Issue Type: Bug
Components: io
Affects Versions: 0.90.1, 0.92.0
Reporter: Jonathan Gray
Assignee: Jonathan Gray
Fix For: 0.90.2, 0.92.0
{code}
public long getHitCount() {
return hitCachingCount.get();
}
{code}
This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-3641)
LruBlockCache.CacheStats.getHitCount() is not using the correct variable
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-3641:
---------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Committed to branch and trunk. Thanks stack.
> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> ------------------------------------------------------------------------
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
> Issue Type: Bug
> Components: io
> Affects Versions: 0.90.1, 0.92.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch, HBASE-3641-v2.patch
>
>
> {code}
> public long getHitCount() {
> return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3641) LruBlockCache.CacheStats.getHitCount()
is not using the correct variable
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-3641:
---------------------------------
Attachment: HBASE-3641-v2.patch
Wow. And I guess we know who screwed it up in the first place =P
Thanks for catching that, Stack. This patch should be right.
> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> ------------------------------------------------------------------------
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
> Issue Type: Bug
> Components: io
> Affects Versions: 0.90.1, 0.92.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch, HBASE-3641-v2.patch
>
>
> {code}
> public long getHitCount() {
> return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3641)
LruBlockCache.CacheStats.getHitCount() is not using the correct variable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006726#comment-13006726 ]
stack commented on HBASE-3641:
------------------------------
Patch looks odd:
{code}
public long getHitCachingCount() {
- return hitCachingCount.get();
+ return hitCount.get();
}
{code}
The method is called getHitCachingCount and it was returning state of hitCachingCount... which seems right?
> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> ------------------------------------------------------------------------
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
> Issue Type: Bug
> Components: io
> Affects Versions: 0.90.1, 0.92.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch
>
>
> {code}
> public long getHitCount() {
> return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HBASE-3641)
LruBlockCache.CacheStats.getHitCount() is not using the correct variable
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13006752#comment-13006752 ]
stack commented on HBASE-3641:
------------------------------
+1 (You must be a little busy Jon -- smile)
> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> ------------------------------------------------------------------------
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
> Issue Type: Bug
> Components: io
> Affects Versions: 0.90.1, 0.92.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch, HBASE-3641-v2.patch
>
>
> {code}
> public long getHitCount() {
> return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3641) LruBlockCache.CacheStats.getHitCount()
is not using the correct variable
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-3641:
---------------------------------
Status: Patch Available (was: Open)
> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> ------------------------------------------------------------------------
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
> Issue Type: Bug
> Components: io
> Affects Versions: 0.90.1, 0.92.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch
>
>
> {code}
> public long getHitCount() {
> return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HBASE-3641) LruBlockCache.CacheStats.getHitCount()
is not using the correct variable
Posted by "Jonathan Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Gray updated HBASE-3641:
---------------------------------
Attachment: HBASE-3641-v1.patch
> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> ------------------------------------------------------------------------
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
> Issue Type: Bug
> Components: io
> Affects Versions: 0.90.1, 0.92.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch
>
>
> {code}
> public long getHitCount() {
> return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-3641)
LruBlockCache.CacheStats.getHitCount() is not using the correct variable
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-3641?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13009955#comment-13009955 ]
Hudson commented on HBASE-3641:
-------------------------------
Integrated in HBase-TRUNK #1803 (See [https://hudson.apache.org/hudson/job/HBase-TRUNK/1803/])
> LruBlockCache.CacheStats.getHitCount() is not using the correct variable
> ------------------------------------------------------------------------
>
> Key: HBASE-3641
> URL: https://issues.apache.org/jira/browse/HBASE-3641
> Project: HBase
> Issue Type: Bug
> Components: io
> Affects Versions: 0.90.1, 0.92.0
> Reporter: Jonathan Gray
> Assignee: Jonathan Gray
> Fix For: 0.90.2, 0.92.0
>
> Attachments: HBASE-3641-v1.patch, HBASE-3641-v2.patch
>
>
> {code}
> public long getHitCount() {
> return hitCachingCount.get();
> }
> {code}
> This should be {{hitCount.get()}}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira